Remove free-pro-team support from Spanish translation of Insights doc (#16730)

* Remove free-pro-team support from Spanish translation of Insights doc

* Throw errors for mismatched products in non-English content pages as well

Author: JamesMGreene

lib/page.js

@@ -65,7 +65,7 @@ class Page {
       // only the homepage will not have this.parentProduct
       .filter(availableVersion => this.parentProduct && !this.parentProduct.versions.includes(availableVersion))
 
-    if (versionsParentProductIsNotAvailableIn.length && this.languageCode === 'en') {
+    if (versionsParentProductIsNotAvailableIn.length) {
       throw new Error(`\`versions\` frontmatter in ${this.fullPath} contains ${versionsParentProductIsNotAvailableIn}, which ${this.parentProduct.id} product is not available in!`)
     }
 

tests/unit/page.js

@@ -389,7 +389,7 @@ describe('catches errors thrown in Page class', () => {
     expect(getPage).toThrowError('versions')
   })
 
-  test('page with a version in frontmatter that its parent product is not available in', () => {
+  test('English page with a version in frontmatter that its parent product is not available in', () => {
     function getPage () {
       return new Page({
         relativePath: 'admin/some-category/some-article-with-mismatched-versions-frontmatter.md',
@@ -400,4 +400,16 @@ describe('catches errors thrown in Page class', () => {
 
     expect(getPage).toThrowError(/`versions` frontmatter.*? product is not available in/)
   })
+
+  test('non-English page with a version in frontmatter that its parent product is not available in', () => {
+    function getPage () {
+      return new Page({
+        relativePath: 'admin/some-category/some-article-with-mismatched-versions-frontmatter.md',
+        basePath: path.join(__dirname, '../fixtures/products'),
+        languageCode: 'es'
+      })
+    }
+
+    expect(getPage).toThrowError(/`versions` frontmatter.*? product is not available in/)
+  })
 })

translations/es-XL/content/insights/installing-and-configuring-github-insights/updating-github-insights.md

@@ -6,7 +6,6 @@ redirect_from:
   - /github/installing-and-configuring-github-insights/updating-github-insights
 permissions: 'Las personas con permisos de lectura para el repositorio de `github/insights-releases` y el acceso administrativo al servidor de aplicaciones pueden actualizar {% data variables.product.prodname_insights %}.'
 versions:
-  free-pro-team: '*'
   enterprise-server: '*'
 ---