Skip to content

Commit 4ce6dd2

Browse files
authored
More misc a11y bits (#23542)
* List-ify guide labels * Use aria-expanded with 🍔 menu
1 parent 5d5360e commit 4ce6dd2

2 files changed

Lines changed: 13 additions & 10 deletions

File tree

components/guides/ArticleCard.tsx

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,22 @@ export const ArticleCard = ({ card, typeLabel }: Props) => {
1616
</div>
1717
<p className="color-fg-muted my-3" dangerouslySetInnerHTML={{ __html: card.intro }} />
1818
{card.topics.length > 0 && (
19-
<div>
19+
<ul style={{ listStyleType: 'none' }}>
2020
{card.topics.map((topic) => {
2121
return (
22-
<Label
23-
key={topic}
24-
data-testid="article-card-topic"
25-
variant="small"
26-
sx={{ bg: 'accent.emphasis', mr: 1 }}
27-
>
28-
{topic}
29-
</Label>
22+
<li className="d-inline-block">
23+
<Label
24+
key={topic}
25+
data-testid="article-card-topic"
26+
variant="small"
27+
sx={{ bg: 'accent.emphasis', mr: 1 }}
28+
>
29+
{topic}
30+
</Label>
31+
</li>
3032
)
3133
})}
32-
</div>
34+
</ul>
3335
)}
3436
</a>
3537
</div>

components/page-header/Header.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ export const Header = () => {
9595
data-testid="mobile-menu-button"
9696
onClick={() => setIsMenuOpen(!isMenuOpen)}
9797
aria-label="Navigation Menu"
98+
aria-expanded={isMenuOpen ? 'true' : 'false'}
9899
>
99100
{isMenuOpen ? <XIcon size="small" /> : <ThreeBarsIcon size="small" />}
100101
</button>

0 commit comments

Comments
 (0)