reduce some repitition in prerendering graphql

Author: mikesurowiec

script/graphql/update-files.js

@@ -16,6 +16,7 @@ const processSchemas = require('./utils/process-schemas')
 const prerenderObjects = require('./utils/prerender-objects')
 const prerenderInputObjects = require('./utils/prerender-input-objects')
 const { prependDatedEntry, createChangelogEntry } = require('./build-changelog')
+const loadData = require('../../lib/site-data')
 
 // check for required PAT
 if (!process.env.GITHUB_TOKEN) {
@@ -37,6 +38,8 @@ const removeHiddenMembersScript = path.join(__dirname, './utils/remove-hidden-sc
 
 const versionsToBuild = Object.keys(allVersions)
 
+const currentLanguage = 'en'
+
 main()
 
 async function main () {
@@ -45,6 +48,14 @@ async function main () {
   const prerenderedObjects = {}
   const prerenderedInputObjects = {}
 
+  const siteData = await loadData()
+
+  // create a bare minimum context for rendering the graphql-object.html layout
+  const context = {
+    currentLanguage,
+    site: siteData[currentLanguage].site,
+  }
+
   for (const version of versionsToBuild) {
     // Get the relevant GraphQL name  for the current version
     // For example, free-pro-team@latest corresponds to dotcom,
@@ -75,13 +86,17 @@ async function main () {
     const schemaJsonPerVersion = await processSchemas(safeForPublicSchema, safeForPublicPreviews)
     updateStaticFile(schemaJsonPerVersion, path.join(graphqlStaticDir, `schema-${graphqlVersion}.json`))
 
+    // Add some version specific data to the context
+    context.graphql = { schemaForCurrentVersion: schemaJsonPerVersion }
+    context.currentVersion = version
+
     // 4. PRERENDER OBJECTS HTML
     // because the objects page is too big to render on page load
-    prerenderedObjects[graphqlVersion] = await prerenderObjects(schemaJsonPerVersion, version)
+    prerenderedObjects[graphqlVersion] = await prerenderObjects(context)
 
     // 5. PRERENDER INPUT OBJECTS HTML
     // because the objects page is too big to render on page load
-    prerenderedInputObjects[graphqlVersion] = await prerenderInputObjects(schemaJsonPerVersion, version)
+    prerenderedInputObjects[graphqlVersion] = await prerenderInputObjects(context)
 
     // 6. UPDATE CHANGELOG
     if (allVersions[version].nonEnterpriseDefault) {

script/graphql/utils/prerender-input-objects.js

@@ -6,27 +6,16 @@ const getMiniTocItems = require('../../../lib/get-mini-toc-items')
 const rewriteLocalLinks = require('../../../lib/rewrite-local-links')
 const includes = path.join(process.cwd(), 'includes')
 const inputObjectIncludeFile = fs.readFileSync(path.join(includes, 'graphql-input-object.html'), 'utf8')
-// TODO need to localize
-const currentLanguage = 'en'
-
-module.exports = async function prerenderInputObjects (schemaJsonPerVersion, version) {
-  const site = await require('../../../lib/site-data')()
-
-  // create a bare minimum context for rendering the graphql-object.html layout
-  const context = {
-    currentLanguage,
-    site: site[currentLanguage].site,
-    graphql: { schemaForCurrentVersion: schemaJsonPerVersion }
-  }
 
+module.exports = async function prerenderInputObjects (context) {
   const inputObjectsArray = []
 
   // render the graphql-object.html layout for every object
-  for (const inputObject of schemaJsonPerVersion.inputObjects) {
+  for (const inputObject of context.graphql.schemaForCurrentVersion.inputObjects) {
     context.item = inputObject
     const inputObjectHtml = await liquid.parseAndRender(inputObjectIncludeFile, context)
     const $ = cheerio.load(inputObjectHtml, { xmlMode: true })
-    rewriteLocalLinks($, version, currentLanguage)
+    rewriteLocalLinks($, context.currentVersion, context.currentLanguage)
     const htmlWithVersionedLinks = $.html()
     inputObjectsArray.push(htmlWithVersionedLinks)
   }

script/graphql/utils/prerender-objects.js

@@ -6,27 +6,16 @@ const getMiniTocItems = require('../../../lib/get-mini-toc-items')
 const rewriteLocalLinks = require('../../../lib/rewrite-local-links')
 const includes = path.join(process.cwd(), 'includes')
 const objectIncludeFile = fs.readFileSync(path.join(includes, 'graphql-object.html'), 'utf8')
-// TODO need to localize
-const currentLanguage = 'en'
-
-module.exports = async function prerenderObjects (schemaJsonPerVersion, version) {
-  const site = await require('../../../lib/site-data')()
-
-  // create a bare minimum context for rendering the graphql-object.html layout
-  const context = {
-    currentLanguage,
-    site: site[currentLanguage].site,
-    graphql: { schemaForCurrentVersion: schemaJsonPerVersion }
-  }
 
+module.exports = async function prerenderObjects (context) {
   const objectsArray = []
 
   // render the graphql-object.html layout for every object
-  for (const object of schemaJsonPerVersion.objects) {
+  for (const object of context.graphql.schemaForCurrentVersion.objects) {
     context.item = object
     const objectHtml = await liquid.parseAndRender(objectIncludeFile, context)
     const $ = cheerio.load(objectHtml, { xmlMode: true })
-    rewriteLocalLinks($, version, currentLanguage)
+    rewriteLocalLinks($, context.currentVersion, context.currentLanguage)
     const htmlWithVersionedLinks = $.html()
     objectsArray.push(htmlWithVersionedLinks)
   }