Skip to content

Commit 3cba453

Browse files
committed
Merge branch 'main' of github.com:github/docs-internal into support-conditionals-in-sublanding-fm
2 parents 4c7af55 + 6d75dee commit 3cba453

8 files changed

Lines changed: 81 additions & 16 deletions

File tree

.github/workflows/check-for-spammy-issues.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,3 +65,14 @@ jobs:
6565
issue_number: issue.number,
6666
body: "This issue appears to have been opened accidentally. I'm going to close it now, but feel free to open a new issue or ask any questions in [discussions](https://github.com/github/docs/discussions)!"
6767
});
68+
69+
// Add the issue to the Done column on the triage board
70+
try {
71+
await github.projects.createCard({
72+
column_id: 11167427,
73+
content_id: context.payload.issue.id,
74+
content_type: "Issue"
75+
});
76+
} catch (error) {
77+
console.log(error);
78+
}

content/developers/webhooks-and-events/securing-your-webhooks.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,4 +94,4 @@ Your language and server implementations may differ from this example code. Howe
9494

9595
* Using a plain `==` operator is **not advised**. A method like [`secure_compare`][secure_compare] performs a "constant time" string comparison, which helps mitigate certain timing attacks against regular equality operators.
9696

97-
[secure_compare]: http://rubydoc.info/github/rack/rack/master/Rack/Utils.secure_compare
97+
[secure_compare]: https://rubydoc.info/github/rack/rack/master/Rack/Utils:secure_compare

content/github/writing-on-github/creating-gists.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ If your site administrator has disabled private mode, you can also use anonymous
3333
You'll receive a notification when:
3434
- You are the author of a gist.
3535
- Someone mentions you in a gist.
36-
- You subscribe to a gist, by clicking **Subscribe** at the top any gist.
36+
- You subscribe to a gist, by clicking **Subscribe** at the top of any gist.
3737

3838
{% if currentVersion == "free-pro-team@latest" or enterpriseServerVersions contains currentVersion %}
3939

@@ -55,13 +55,15 @@ Gist supports mapping GeoJSON files. These maps are displayed in embedded gists,
5555

5656
### Creating a gist
5757

58-
You can also drag and drop a text file from your desktop directly into the gist editor.
58+
Follow the steps below to create a gist.
5959

6060
{% if currentVersion == "free-pro-team@latest" or currentVersion ver_gt "enterprise-server@2.19" or currentVersion == "github-ae@latest" %}
6161
{% note %}
6262

6363
You can also create a gist using the {% data variables.product.prodname_cli %}. For more information, see "[`gh gist create`](https://cli.github.com/manual/gh_gist_create)" in the {% data variables.product.prodname_cli %} documentation.
6464

65+
Alternatively, you can drag and drop a text file from your desktop directly into the editor.
66+
6567
{% endnote %}
6668
{% endif %}
6769

@@ -70,7 +72,7 @@ You can also create a gist using the {% data variables.product.prodname_cli %}.
7072
3. Type an optional description and name for your gist.
7173
![Gist name description](/assets/images/help/gist/gist_name_description.png)
7274

73-
4. Type the text of your gist into the gist text box.
75+
4. Type the text of your gist into the gist text box.
7476
![Gist text box](/assets/images/help/gist/gist_text_box.png)
7577

7678
5. Optionally, to create {% if currentVersion == "github-ae@latest" %}an internal{% else %}a public{% endif %} gist, click {% octicon "triangle-down" aria-label="The downwards triangle icon" %}, then click **Create {% if currentVersion == "github-ae@latest" %}internal{% else %}public{% endif %} gist**.

data/release-notes/2-21/18.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
date: '2021-04-01'
2+
sections:
3+
security_fixes:
4+
- "**HIGH:** An improper access control vulnerability was identified in GitHub Enterprise Server that allowed access tokens generated via a GitHub App's [web authentication flow](https://docs.github.com/en/developers/apps/identifying-and-authorizing-users-for-github-apps#web-application-flow) to read private repository metadata without requiring appropriate permissions. This vulnerability affected all versions of GitHub Enterprise Server prior to 3.0.4 and was fixed in 3.0.4, 2.22.10, and 2.21.18. This vulnerability was reported via the GitHub Bug Bounty program and has been assigned CVE-2021-22865."
5+
- Packages have been updated to the latest security versions.
6+
bugs:
7+
- Services were not transitioning to new log files as part of log rotation, resulting in increased disk usage.
8+
- The label on search results for internal repositories was shown as "Private" instead of "Internal".
9+
known_issues:
10+
- On a freshly set up GitHub Enterprise Server without any users, an attacker could create the first admin user.
11+
- Custom firewall rules are not maintained during an upgrade.
12+
- Git LFS tracked files [uploaded through the web interface](https://github.com/blog/2105-upload-files-to-your-repositories) are incorrectly added directly to the repository.
13+
- Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters.
14+
- When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results.
15+
- Security alerts are not reported when pushing to a repository on the command line.

data/release-notes/2-22/10.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
date: '2021-04-01'
2+
sections:
3+
security_fixes:
4+
- "**HIGH:** An improper access control vulnerability was identified in GitHub Enterprise Server that allowed access tokens generated via a GitHub App's [web authentication flow](https://docs.github.com/en/developers/apps/identifying-and-authorizing-users-for-github-apps#web-application-flow) to read private repository metadata without requiring appropriate permissions. This vulnerability affected all versions of GitHub Enterprise Server prior to 3.0.4 and was fixed in 3.0.4, 2.22.10, and 2.21.18. This vulnerability was reported via the GitHub Bug Bounty program and has been assigned CVE-2021-22865."
5+
- Packages have been updated to the latest security versions.
6+
bugs:
7+
- A timezone set on GitHub Enterprise 11.10.x or earlier was not being used by some services which were defaulting to UTC time.
8+
- Services were not transitioning to new log files as part of log rotation, resulting in increased disk usage.
9+
- The label on search results for internal repositories was shown as "Private" instead of "Internal".
10+
known_issues:
11+
- On a freshly set up GitHub Enterprise Server without any users, an attacker could create the first admin user.
12+
- Custom firewall rules are not maintained during an upgrade.
13+
- Git LFS tracked files [uploaded through the web interface](https://github.com/blog/2105-upload-files-to-your-repositories) are incorrectly added directly to the repository.
14+
- Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters.
15+
- When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results.

data/release-notes/3-0/4.yml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
date: '2021-04-01'
2+
intro: The minimum infrastructure requirements have increased for {% data variables.product.prodname_ghe_server %} 3.0+. For more information, see "[About minimum requirements for GitHub Enterprise Server 3.0 and later](/admin/enterprise-management/upgrading-github-enterprise-server#about-minimum-requirements-for-github-enterprise-server-30-and-later)."
3+
sections:
4+
security_fixes:
5+
- "**HIGH:** An improper access control vulnerability was identified in GitHub Enterprise Server that allowed access tokens generated via a GitHub App's [web authentication flow](https://docs.github.com/en/developers/apps/identifying-and-authorizing-users-for-github-apps#web-application-flow) to read private repository metadata without requiring appropriate permissions. This vulnerability affected all versions of GitHub Enterprise Server prior to 3.0.4 and was fixed in 3.0.4, 2.22.10, and 2.21.18. This vulnerability was reported via the GitHub Bug Bounty program and has been assigned CVE-2021-22865."
6+
- Packages have been updated to the latest security versions.
7+
bugs:
8+
- When maintenance mode was enabled, some services continued to be listed as "active processes" even though they were expected to be running, and should not have been listed.
9+
- After upgrading from 2.22.x to 3.0.x with GitHub Actions enabled, the self-hosted runner version was not updated and no self-hosted updates were made.
10+
- Old GitHub Pages builds that were created from commits to a `gh-pages` branch were not cleaned up leading to increased disk usage.
11+
- '`memcached` was not running on active replicas.'
12+
- Upgrade failed when updating file permissions when GitHub Actions was enabled.
13+
- A timezone set on GitHub Enterprise 11.10.x or earlier was not being used by some services which were defaulting to UTC time.
14+
- Services were not transitioning to new log files as part of log rotation, resulting in increased disk usage.
15+
- The `ghe-saml-mapping-csv` command-line utility produced a warning message.
16+
- The label on search results for internal repositories was shown as "Private" instead of "Internal".
17+
known_issues:
18+
- On a freshly set up GitHub Enterprise Server without any users, an attacker could create the first admin user.
19+
- Custom firewall rules are not maintained during an upgrade.
20+
- Git LFS tracked files [uploaded through the web interface](https://github.com/blog/2105-upload-files-to-your-repositories) are incorrectly added directly to the repository.
21+
- Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters.
22+
- When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results.

lib/rest/static/decorated/api.github.com.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22557,7 +22557,7 @@
2255722557
}
2255822558
],
2255922559
"summary": "Delete a package for an organization",
22560-
"description": "Deletes an entire package in an organization. You cannot delete a public package if any version of the package has more than 25 downloads. In this scenario, contact GitHub support for further assistance.\n\nTo use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the `packages:read` scope. In addition:\n- If `package_type` is not `container`, your token must also include the `repo` scope.\n- If `package_type` is `container`, you must also have admin permissions to the container you want to delete.",
22560+
"description": "Deletes an entire package in an organization. You cannot delete a public package if any version of the package has more than 5,000 downloads. In this scenario, contact GitHub support for further assistance.\n\nTo use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the `packages:read` scope. In addition:\n- If `package_type` is not `container`, your token must also include the `repo` scope.\n- If `package_type` is `container`, you must also have admin permissions to the container you want to delete.",
2256122561
"tags": [
2256222562
"packages"
2256322563
],
@@ -22600,7 +22600,7 @@
2260022600
}
2260122601
],
2260222602
"bodyParameters": [],
22603-
"descriptionHTML": "<p>Deletes an entire package in an organization. You cannot delete a public package if any version of the package has more than 25 downloads. In this scenario, contact GitHub support for further assistance.</p>\n<p>To use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the <code>packages:read</code> scope. In addition:</p>\n<ul>\n<li>If <code>package_type</code> is not <code>container</code>, your token must also include the <code>repo</code> scope.</li>\n<li>If <code>package_type</code> is <code>container</code>, you must also have admin permissions to the container you want to delete.</li>\n</ul>"
22603+
"descriptionHTML": "<p>Deletes an entire package in an organization. You cannot delete a public package if any version of the package has more than 5,000 downloads. In this scenario, contact GitHub support for further assistance.</p>\n<p>To use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the <code>packages:read</code> scope. In addition:</p>\n<ul>\n<li>If <code>package_type</code> is not <code>container</code>, your token must also include the <code>repo</code> scope.</li>\n<li>If <code>package_type</code> is <code>container</code>, you must also have admin permissions to the container you want to delete.</li>\n</ul>"
2260422604
},
2260522605
{
2260622606
"verb": "post",
@@ -23013,7 +23013,7 @@
2301323013
}
2301423014
],
2301523015
"summary": "Delete package version for an organization",
23016-
"description": "Deletes a specific package version in an organization. If the package is public and the package version has more than 25 downloads, you cannot delete the package version. In this scenario, contact GitHub support for further assistance.\n\nTo use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the `packages:read` scope. In addition:\n- If `package_type` is not `container`, your token must also include the `repo` scope.\n- If `package_type` is `container`, you must also have admin permissions to the container you want to delete.",
23016+
"description": "Deletes a specific package version in an organization. If the package is public and the package version has more than 5,000 downloads, you cannot delete the package version. In this scenario, contact GitHub support for further assistance.\n\nTo use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the `packages:read` scope. In addition:\n- If `package_type` is not `container`, your token must also include the `repo` scope.\n- If `package_type` is `container`, you must also have admin permissions to the container you want to delete.",
2301723017
"tags": [
2301823018
"packages"
2301923019
],
@@ -23056,7 +23056,7 @@
2305623056
}
2305723057
],
2305823058
"bodyParameters": [],
23059-
"descriptionHTML": "<p>Deletes a specific package version in an organization. If the package is public and the package version has more than 25 downloads, you cannot delete the package version. In this scenario, contact GitHub support for further assistance.</p>\n<p>To use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the <code>packages:read</code> scope. In addition:</p>\n<ul>\n<li>If <code>package_type</code> is not <code>container</code>, your token must also include the <code>repo</code> scope.</li>\n<li>If <code>package_type</code> is <code>container</code>, you must also have admin permissions to the container you want to delete.</li>\n</ul>"
23059+
"descriptionHTML": "<p>Deletes a specific package version in an organization. If the package is public and the package version has more than 5,000 downloads, you cannot delete the package version. In this scenario, contact GitHub support for further assistance.</p>\n<p>To use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the <code>packages:read</code> scope. In addition:</p>\n<ul>\n<li>If <code>package_type</code> is not <code>container</code>, your token must also include the <code>repo</code> scope.</li>\n<li>If <code>package_type</code> is <code>container</code>, you must also have admin permissions to the container you want to delete.</li>\n</ul>"
2306023060
},
2306123061
{
2306223062
"verb": "post",
@@ -89438,7 +89438,7 @@
8943889438
}
8943989439
],
8944089440
"summary": "Delete a package for the authenticated user",
89441-
"description": "Deletes a package owned by the authenticated user. You cannot delete a public package if any version of the package has more than 25 downloads. In this scenario, contact GitHub support for further assistance.\n\nTo use this endpoint, you must authenticate using an access token with the `packages:read` and `packages:delete` scope.\nIf `package_type` is not `container`, your token must also include the `repo` scope.",
89441+
"description": "Deletes a package owned by the authenticated user. You cannot delete a public package if any version of the package has more than 5,000 downloads. In this scenario, contact GitHub support for further assistance.\n\nTo use this endpoint, you must authenticate using an access token with the `packages:read` and `packages:delete` scope.\nIf `package_type` is not `container`, your token must also include the `repo` scope.",
8944289442
"tags": [
8944389443
"packages"
8944489444
],
@@ -89481,7 +89481,7 @@
8948189481
}
8948289482
],
8948389483
"bodyParameters": [],
89484-
"descriptionHTML": "<p>Deletes a package owned by the authenticated user. You cannot delete a public package if any version of the package has more than 25 downloads. In this scenario, contact GitHub support for further assistance.</p>\n<p>To use this endpoint, you must authenticate using an access token with the <code>packages:read</code> and <code>packages:delete</code> scope.\nIf <code>package_type</code> is not <code>container</code>, your token must also include the <code>repo</code> scope.</p>"
89484+
"descriptionHTML": "<p>Deletes a package owned by the authenticated user. You cannot delete a public package if any version of the package has more than 5,000 downloads. In this scenario, contact GitHub support for further assistance.</p>\n<p>To use this endpoint, you must authenticate using an access token with the <code>packages:read</code> and <code>packages:delete</code> scope.\nIf <code>package_type</code> is not <code>container</code>, your token must also include the <code>repo</code> scope.</p>"
8948589485
},
8948689486
{
8948789487
"verb": "post",
@@ -89858,7 +89858,7 @@
8985889858
}
8985989859
],
8986089860
"summary": "Delete a package version for the authenticated user",
89861-
"description": "Deletes a specific package version for a package owned by the authenticated user. If the package is public and the package version has more than 25 downloads, you cannot delete the package version. In this scenario, contact GitHub support for further assistance.\n\nTo use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the `packages:read` scope.\nIf `package_type` is not `container`, your token must also include the `repo` scope.",
89861+
"description": "Deletes a specific package version for a package owned by the authenticated user. If the package is public and the package version has more than 5,000 downloads, you cannot delete the package version. In this scenario, contact GitHub support for further assistance.\n\nTo use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the `packages:read` scope.\nIf `package_type` is not `container`, your token must also include the `repo` scope.",
8986289862
"tags": [
8986389863
"packages"
8986489864
],
@@ -89901,7 +89901,7 @@
8990189901
}
8990289902
],
8990389903
"bodyParameters": [],
89904-
"descriptionHTML": "<p>Deletes a specific package version for a package owned by the authenticated user. If the package is public and the package version has more than 25 downloads, you cannot delete the package version. In this scenario, contact GitHub support for further assistance.</p>\n<p>To use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the <code>packages:read</code> scope.\nIf <code>package_type</code> is not <code>container</code>, your token must also include the <code>repo</code> scope.</p>"
89904+
"descriptionHTML": "<p>Deletes a specific package version for a package owned by the authenticated user. If the package is public and the package version has more than 5,000 downloads, you cannot delete the package version. In this scenario, contact GitHub support for further assistance.</p>\n<p>To use this endpoint, you must have admin permissions in the organization and authenticate using an access token with the <code>packages:read</code> scope.\nIf <code>package_type</code> is not <code>container</code>, your token must also include the <code>repo</code> scope.</p>"
8990589905
},
8990689906
{
8990789907
"verb": "post",

0 commit comments

Comments
 (0)