Skip to content

Commit 3aeac43

Browse files
authored
Merge branch 'main' into deployment-guides/add-gke
2 parents 8162972 + 7266455 commit 3aeac43

63 files changed

Lines changed: 718 additions & 824 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/repo-sync.yml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ jobs:
4444
github_token: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
4545

4646
- name: Create pull request
47+
id: create-pull
4748
uses: repo-sync/pull-request@33777245b1aace1a58c87a29c90321aa7a74bd7d
4849
env:
4950
GITHUB_TOKEN: ${{ secrets.OCTOMERGER_PAT_WITH_REPO_AND_WORKFLOW_SCOPE }}
@@ -70,6 +71,35 @@ jobs:
7071
github-token: ${{ secrets.GITHUB_TOKEN }}
7172
number: ${{ steps.find-pull-request.outputs.number }}
7273

74+
# There are cases where the branch becomes out-of-date in between the time this workflow began and when the pull request is created/updated
75+
- name: Update branch
76+
if: ${{ steps.find-pull-request.outputs.number }}
77+
uses: actions/github-script@626af12fe9a53dc2972b48385e7fe7dec79145c9
78+
with:
79+
github-token: ${{ secrets.GITHUB_TOKEN }}
80+
script: |
81+
const mainHeadSha = await github.git.getRef({
82+
...context.repo,
83+
ref: 'heads/main'
84+
})
85+
console.log(`heads/main sha: ${mainHeadSha.data.object.sha}`)
86+
87+
const pull = await github.pulls.get({
88+
...context.repo,
89+
pull_number: parseInt(${{ steps.find-pull-request.outputs.number }})
90+
})
91+
console.log(`Pull request base sha: ${pull.data.base.sha}`)
92+
93+
if (mainHeadSha.data.object.sha !== pull.data.base.sha || pull.data.mergeable_state === 'behind') {
94+
const updateBranch = await github.pulls.updateBranch({
95+
...context.repo,
96+
pull_number: parseInt(${{ steps.find-pull-request.outputs.number }})
97+
})
98+
console.log(updateBranch.data.message)
99+
} else {
100+
console.log(`Branch is already up-to-date`)
101+
}
102+
73103
- name: Send Slack notification if workflow fails
74104
uses: someimportantcompany/github-actions-slack-message@0b470c14b39da4260ed9e3f9a4f1298a74ccdefd
75105
if: failure()

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ We (usually the docs team, but sometimes GitHub product managers, engineers, or
152152
You should always review your own PR first.
153153

154154
For content changes, make sure that you:
155-
- [ ] Confirm that the changes address every part of the content strategy plan from your issue (if there are differences, explain them).
155+
- [ ] Confirm that the changes address every part of the content design plan from your issue (if there are differences, explain them).
156156
- [ ] Review the content for technical accuracy.
157157
- [ ] Review the entire pull request using the [localization checklist](contributing/localization-checklist.md).
158158
- [ ] Copy-edit the changes for grammar, spelling, and adherence to the style guide.

app.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@
33
"env": {
44
"NODE_ENV": "production",
55
"NPM_CONFIG_PRODUCTION": "true",
6-
"ENABLED_LANGUAGES": "en, de"
6+
"ENABLED_LANGUAGES": "en"
77
},
88
"buildpacks": [
9-
{ "url": "https://github.com/DataDog/heroku-buildpack-datadog.git#1.21" },
109
{ "url": "heroku/nodejs" }
1110
],
1211
"formation": {

content/developers/apps/creating-a-github-app-using-url-parameters.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ Permission | Description
7979
[`single_file`](/rest/reference/permissions-required-for-github-apps/#permission-on-single-file) | Grants access to the [Contents API](/rest/reference/repos#contents). Can be one of: `none`, `read`, or `write`.
8080
[`starring`](/rest/reference/permissions-required-for-github-apps/#permission-on-starring) | Grants access to the [Starring API](/rest/reference/activity#starring). Can be one of: `none`, `read`, or `write`.
8181
[`statuses`](/rest/reference/permissions-required-for-github-apps/#permission-on-statuses) | Grants access to the [Statuses API](/rest/reference/repos#statuses). Can be one of: `none`, `read`, or `write`.
82-
[`team_discussions`](/rest/reference/permissions-required-for-github-apps/#permission-on-team-discussions) | Grants access to the [Team Discussions API](/rest/reference/teams#discussions) and the [Team Discussion Comments API](/rest/reference/teams#discussion-comments). Can be one of: `none`, `read`, or `write`.
83-
`vulnerability_alerts`| Grants access to receive security alerts for vulnerable dependencies in a repository. See "[About security alerts for vulnerable dependencies](/articles/about-security-alerts-for-vulnerable-dependencies)" to learn more. Can be one of: `none` or `read`.
82+
[`team_discussions`](/rest/reference/permissions-required-for-github-apps/#permission-on-team-discussions) | Grants access to the [Team Discussions API](/rest/reference/teams#discussions) and the [Team Discussion Comments API](/rest/reference/teams#discussion-comments). Can be one of: `none`, `read`, or `write`.{% if currentVersion == "free-pro-team@latest" or currentVersion ver_gt "enterprise-server@1.19" %}
83+
`vulnerability_alerts`| Grants access to receive security alerts for vulnerable dependencies in a repository. See "[About security alerts for vulnerable dependencies](/articles/about-security-alerts-for-vulnerable-dependencies)" to learn more. Can be one of: `none` or `read`.{% endif %}
8484
`watching` | Grants access to list and change repositories a user is subscribed to. Can be one of: `none`, `read`, or `write`.
8585

8686
### {% data variables.product.prodname_github_app %} webhook events

content/developers/apps/identifying-and-authorizing-users-for-github-apps.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ If the user accepts your request, GitHub redirects back to your site with a temp
6767

6868
{% endnote %}
6969

70-
Exchange this `code` for an access token. {% if currentVersion == "free-pro-team@latest" or currentVersion ver_gt "enterprise-server@2.21" or currentVersion == "github-ae@latest" %} When expiring tokens are enabled, the access token expires in 8 hours and the refresh token expires in 6 months. Every time you refresh the token, you get a new refresh token. For more information, see "[Refreshing user-to-server access tokens](/developers/apps/refreshing-user-to-server-access-tokens)."
70+
Exchange this `code` for an access token. {% if currentVersion == "free-pro-team@latest" %} When expiring tokens are enabled, the access token expires in 8 hours and the refresh token expires in 6 months. Every time you refresh the token, you get a new refresh token. For more information, see "[Refreshing user-to-server access tokens](/developers/apps/refreshing-user-to-server-access-tokens)."
7171

7272
Expiring user tokens are currently part of the user-to-server token expiration beta and subject to change. To opt-in to the user-to-server token expiration beta feature, see "[Activating beta features for apps](/developers/apps/activating-beta-features-for-apps)."{% endif %}
7373

content/developers/apps/suspending-a-github-app-installation.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,11 @@ versions:
77
free-pro-team: '*'
88
---
99

10-
{% if currentVersion == "free-pro-team@latest" or currentVersion ver_gt "enterprise-server@2.21" %}
1110
{% note %}
1211

1312
**Note:** {% data reusables.pre-release-program.suspend-installation-beta %}
1413

1514
{% endnote %}
16-
{% endif %}
1715

1816
### Suspending a GitHub App
1917

content/developers/github-marketplace/creating-apps-for-github-marketplace.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@ intro: 'You can list free and paid tools for developers to use in {% data variab
44
mapTopic: true
55
versions:
66
free-pro-team: '*'
7-
enterprise-server: '*'
87
---
98

content/developers/github-marketplace/pricing-plans-for-github-marketplace-apps.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ Customers can start a free trial for any paid plan on a Marketplace listing that
4848

4949
Free trials have a fixed length of 14 days. Customers are notified 4 days before the end of their trial period (on day 11 of the free trial) that their plan will be upgraded. At the end of a free trial, customers will be auto-enrolled into the plan they are trialing if they do not cancel.
5050

51-
For more information, see: "[Handling new purchases and free trials](/developers/github-marketplace/integrating-with-the-github-marketplace-api/handling-new-purchases-and-free-trials/)."
51+
For more information, see: "[Handling new purchases and free trials](/developers/github-marketplace/handling-new-purchases-and-free-trials/)."
5252

5353
{% note %}
5454

content/developers/github-marketplace/requirements-for-listing-an-app.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ In addition to the requirements for all apps above, each app that you offer as a
5353
- {% data variables.product.prodname_github_app %}s should have a minimum of 100 installations.
5454
- {% data variables.product.prodname_oauth_app %}s should have a minimum of 200 users.
5555
- All paid apps must handle {% data variables.product.prodname_marketplace %} purchase events for new purchases, upgrades, downgrades, cancellations, and free trials. For more information, see "[Billing requirements for paid apps](#billing-requirements-for-paid-apps)" below.
56-
- Publishing organizations must have a verified domain and must enable two-factor authentication. For more information, see "[Requiring two-factor authentication in your organization](/github/setting-up-and-managing-organizations-and-teams/requiring-two-factor-authentication-in-your-organization.")
56+
- Publishing organizations must have a verified domain and must enable two-factor authentication. For more information, see "[Requiring two-factor authentication in your organization](/github/setting-up-and-managing-organizations-and-teams/requiring-two-factor-authentication-in-your-organization)."
5757

5858
When you are ready to publish the app on {% data variables.product.prodname_marketplace %} you must request verification for the listing.
5959

content/developers/overview/managing-deploy-keys.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@ If you don't want to use SSH keys, you can use [HTTPS with OAuth tokens][git-aut
4444
* Users don't have to change their local SSH settings.
4545
* Multiple tokens (one for each user) are not needed; one token per server is enough.
4646
* A token can be revoked at any time, turning it essentially into a one-use password.
47+
{% if enterpriseServerVersions contains currentVersion %}
4748
* Generating new tokens can be easily scripted using [the OAuth API](/rest/reference/oauth-authorizations#create-a-new-authorization).
49+
{% endif %}
4850

4951
##### Cons
5052

0 commit comments

Comments
 (0)