Parentheticals -> parentheses (#17130)

Author: heiskr

lib/encode-bracketed-parentheticals.js lib/encode-bracketed-parentheses.jslib/encode-bracketed-parentheticals.js renamed to lib/encode-bracketed-parentheses.js

@@ -1,6 +1,6 @@
 // prevent `[foo] (bar)` strings with a space between from being interpreted as markdown links
 // by encoding the space character
 
-module.exports = function encodeBracketedParentheticals (input) {
+module.exports = function encodeBracketedParentheses (input) {
   return input.replace(/] \(/g, '] (')
 }

lib/page.js

@@ -7,7 +7,7 @@ const getMapTopicContent = require('./get-map-topic-content')
 const rewriteAssetPathsToS3 = require('./rewrite-asset-paths-to-s3')
 const rewriteLocalLinks = require('./rewrite-local-links')
 const getApplicableVersions = require('./get-applicable-versions')
-const encodeBracketedParentheticals = require('./encode-bracketed-parentheticals')
+const encodeBracketedParentheses = require('./encode-bracketed-parentheses')
 const generateRedirectsForPermalinks = require('./redirects/permalinks')
 const getEnglishHeadings = require('./get-english-headings')
 const useEnglishHeadings = require('./use-english-headings')
@@ -69,7 +69,7 @@ class Page {
     this.markdown = content
 
     // prevent `[foo] (bar)` strings with a space between from being interpreted as markdown links
-    this.markdown = encodeBracketedParentheticals(this.markdown)
+    this.markdown = encodeBracketedParentheses(this.markdown)
 
     Object.assign(this, data)
 

lib/site-data.js

@@ -3,13 +3,13 @@ const flat = require('flat')
 const { get, set } = require('lodash')
 const languages = require('./languages')
 const dataDirectory = require('./data-directory')
-const encodeBracketedParentheticals = require('./encode-bracketed-parentheticals')
+const encodeBracketedParentheses = require('./encode-bracketed-parentheses')
 
 const loadSiteDataFromDir = dir => ({
   site: {
     data: dataDirectory(path.join(dir, 'data'), {
       preprocess: dataString =>
-        encodeBracketedParentheticals(dataString.trimEnd()),
+        encodeBracketedParentheses(dataString.trimEnd()),
       ignorePatterns: [/README\.md$/]
     })
   }

tests/content/site-data.js

@@ -75,7 +75,7 @@ describe('siteData module (English)', () => {
     expect(reusable.includes('1. ')).toBe(true)
   })
 
-  test.skip('encodes bracketed parentheticals to prevent them from becoming links', async () => {
+  test.skip('encodes bracketed parentheses to prevent them from becoming links', async () => {
     const reusable = get(data, 'ja.site.data.reusables.organizations.team_name')
     const expectation = `reusable should contain a bracket followed by a space. Actual value: ${reusable}`
     expect(reusable.includes('] ('), expectation).toBe(true)