Skip to content

Commit 33c5ce2

Browse files
Updating images styling and accessibility for minitocitems (#22976)
* updating images styling on design systems feedback * maintaining ul li structure for accessiblity Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com>
1 parent 8cd04f5 commit 33c5ce2

3 files changed

Lines changed: 6 additions & 7 deletions

File tree

components/article/ArticlePage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export const ArticlePage = () => {
4646
const renderTocItem = (item: MiniTocItem) => {
4747
return (
4848
<ActionList.Item
49-
as="div"
49+
as="li"
5050
key={item.contents}
5151
className={item.platform}
5252
sx={{ listStyle: 'none', padding: '2px' }}

stylesheets/images.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,11 @@
77
}
88

99
.markdown-body .procedural-image-wrapper img {
10-
border-radius: 5px;
11-
border: 2px solid var(--color-border-subtle);
1210
width: auto;
1311
height: auto;
1412
max-height: 500px;
1513
padding: 0;
14+
box-shadow: var(--color-shadow-medium);
1615
}
1716

1817
// make sure images that contain emoji render at the expected size

tests/rendering/server.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ describe('server', () => {
337337
)
338338
expect($('h2#in-this-article').length).toBe(1)
339339
expect($('h2#in-this-article + div div ul').length).toBeGreaterThan(0) // non-indented items
340-
expect($('h2#in-this-article + div div ul div div div div ul.ml-3').length).toBeGreaterThan(0) // indented items
340+
expect($('h2#in-this-article + div div ul li div div div ul.ml-3').length).toBeGreaterThan(0) // indented items
341341
})
342342

343343
test('does not render mini TOC in articles with only one heading', async () => {
@@ -878,11 +878,11 @@ describe('extended Markdown', () => {
878878
test('renders expected mini TOC headings in platform-specific content', async () => {
879879
const $ = await getDOM('/en/github/using-git/associating-text-editors-with-git')
880880
expect($('h2#in-this-article').length).toBe(1)
881-
expect($('h2#in-this-article + div div ul div.extended-markdown.mac').length).toBeGreaterThan(1)
881+
expect($('h2#in-this-article + div div ul li.extended-markdown.mac').length).toBeGreaterThan(1)
882882
expect(
883-
$('h2#in-this-article + div div ul div.extended-markdown.windows').length
883+
$('h2#in-this-article + div div ul li.extended-markdown.windows').length
884884
).toBeGreaterThan(1)
885-
expect($('h2#in-this-article + div div ul div.extended-markdown.linux').length).toBeGreaterThan(
885+
expect($('h2#in-this-article + div div ul li.extended-markdown.linux').length).toBeGreaterThan(
886886
1
887887
)
888888
})

0 commit comments

Comments
 (0)