use path.join instead of string interpolation for consistency

Author: sarahs

lib/all-products.js

@@ -46,7 +46,7 @@ sortedProductIds.forEach(productId => {
   const toc = slash(path.join(dir, 'index.md'))
   const { data } = frontmatter(fs.readFileSync(toc, 'utf8'))
   const applicableVersions = getApplicableVersions(data.versions, toc)
-  const href = `/${applicableVersions[0]}/${productId}`
+  const href = slash(path.join('/', applicableVersions[0], productId))
 
   internalProducts[productId] = {
     id: productId,

lib/all-versions.js

@@ -7,8 +7,7 @@ const versionDelimiter = '@'
 const latestNonNumberedRelease = 'latest'
 
 const plans = [
-  { // free-pro-team is **not** a user-facing version and is stripped from URLs.
-    // See lib/remove-fpt-from-path.js for details.
+  {
     plan: 'free-pro-team',
     planTitle: 'Free, Pro, and Team',
     releases: [latestNonNumberedRelease],

lib/redirects/get-docs-path-from-developer-path.js

@@ -1,3 +1,4 @@
+const path = require('path')
 const patterns = require('../patterns')
 const { latest } = require('../enterprise-server-releases')
 const { getPathWithoutLanguage, getPathWithoutVersion } = require('../path-utils')
@@ -73,7 +74,7 @@ module.exports = function getDocsPathFromDeveloperPath (oldDeveloperPath, allRed
 
   // old developer routes that include 'enterprise-admin' should always redirect to enterprise server
   if (fragment && newPath.includes('/rest/reference/enterprise-admin') && !patterns.enterpriseServer.test(newPath)) {
-    newPath = `/en/enterprise-server@${latest}${getPathWithoutLanguage(getPathWithoutVersion(newPath))}`
+    newPath = path.join('/en', `enterprise-server@${latest}`, getPathWithoutLanguage(getPathWithoutVersion(newPath)))
   }
 
   // show an error if the page to be redirected to doesn't exist