Skip to content

Commit 308aa9c

Browse files
authored
Fix heading sizes (#22968)
* Align heading sizes with Primer * Make the headings on other pages match normal pages
1 parent fa81506 commit 308aa9c

5 files changed

Lines changed: 7 additions & 19 deletions

File tree

components/GenericError.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export function GenericError() {
2020

2121
<div className="container-xl p-responsive py-9 width-full flex-1">
2222
<article className="col-md-10 col-lg-7 mx-auto">
23-
<h1 className="mb-3 pb-3 border-bottom">Ooops!</h1>
23+
<h1>Ooops!</h1>
2424
<Lead>It looks like something went wrong.</Lead>
2525
<p className="f3">
2626
We track these errors automatically, but if the problem persists please feel free to

components/landing/LandingHero.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ export const LandingHero = () => {
2222

2323
return (
2424
<header className="d-lg-flex gutter-lg mb-6">
25-
<div className={cx(product_video && 'col-12 col-lg-6 mb-3 mb-lg-0')}>
26-
<h1 className="mb-3">
25+
<div className={cx('col-12 mb-3 mb-lg-0', product_video && 'col-lg-6')}>
26+
<h1>
2727
{shortTitle}{' '}
2828
{beta_product && <span className="Label Label--success v-align-middle">Beta</span>}
2929
</h1>

components/sublanding/SubLandingHero.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ export const SubLandingHero = () => {
4343

4444
return (
4545
<div>
46-
<header className="d-flex gutter mb-6">
46+
<header className="d-flex gutter mb-6 my-4">
4747
<div className="col-12">
48-
<h1 className="my-3">{title} guides</h1>
48+
<h1>{title} guides</h1>
4949
{intro && <Lead data-search="lead">{intro}</Lead>}
5050
</div>
5151
</header>

components/ui/MarkdownContent/stylesheets/headers.scss

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,11 @@
44
h3,
55
h4,
66
h5 {
7-
padding-top: 16px;
8-
}
9-
h2 {
10-
font-size: 1.25em;
7+
padding-top: 1rem;
118
}
129

1310
// all h2 headers that are links should be blue-500
1411
h2 a {
1512
color: var(--color-accent-fg);
1613
}
17-
h3 {
18-
font-size: 1em;
19-
}
20-
h4 {
21-
font-size: 0.875em;
22-
}
23-
h5 {
24-
font-size: 0.85em;
25-
}
2614
}

pages/404.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const Custom404 = () => {
1717

1818
<div className="container-xl p-responsive py-6 width-full flex-1">
1919
<article className="col-md-10 col-lg-7 mx-auto">
20-
<h1 className="mb-3 pb-3 border-bottom">Ooops!</h1>
20+
<h1>Ooops!</h1>
2121
<Lead>It looks like this page doesn't exist.</Lead>
2222
<p className="f3">
2323
We track these errors automatically, but if the problem persists please feel free to

0 commit comments

Comments
 (0)