Replace custom get-changed-files action with tj-actions/changed-files (#60111)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: heiskr

.github/actions/get-changed-files/action.yml

@@ -30,29 +30,23 @@ jobs:
 
       - name: Get changed content/data files
         id: changed_files
-        uses: ./.github/actions/get-changed-files
+        uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323 # v47.0.5
         with:
           files: |
             content/**
             data/**
 
       - name: Print content linter annotations if changed content/data files
-        if: steps.changed_files.outputs.filtered_changed_files
+        if: steps.changed_files.outputs.any_modified == 'true'
         env:
-          # Make it an environment variable so that its value doesn't need to be escaped.
-          # See https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable
-          CHANGED_FILES: |-
-            ${{ steps.changed_files.outputs.filtered_changed_files }}
+          CHANGED_FILES: ${{ steps.changed_files.outputs.all_modified_files }}
         # If there are errors, using `--print-annotations` will make it
         # so it does *not* exit non-zero.
         # This is so that all warnings and errors are printed.
         run: npm run lint-content -- --print-annotations --paths $CHANGED_FILES
 
       - name: Run content linter if changed content/data files
-        if: steps.changed_files.outputs.filtered_changed_files
+        if: steps.changed_files.outputs.any_modified == 'true'
         env:
-          # Make it an environment variable so that its value doesn't need to be escaped.
-          # See https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable
-          CHANGED_FILES: |-
-            ${{ steps.changed_files.outputs.filtered_changed_files }}
+          CHANGED_FILES: ${{ steps.changed_files.outputs.all_modified_files }}
         run: npm run lint-content -- --errors-only --paths $CHANGED_FILES

.github/actions/get-changed-files/get-changed-files.sh

@@ -40,7 +40,7 @@ jobs:
 
       - name: Get changed files
         id: changed-files
-        uses: tj-actions/changed-files@e0021407031f5be11a464abee9a0776171c79891 # v45
+        uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323 # v47.0.5
         with:
           files: |
             content/**/*.md

.github/workflows/content-lint-markdown.yml

@@ -48,27 +48,25 @@ jobs:
 
       - name: Get changed content files
         id: changed_files
-        uses: ./.github/actions/get-changed-files
+        uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323 # v47.0.5
         with:
           files: 'content/**/*.md'
-          # For workflow_dispatch, compare against main
-          base: ${{ github.event_name == 'workflow_dispatch' && 'main' || '' }}
 
       - name: Disable Next.js telemetry
         run: npx next telemetry disable
 
       - name: Start server in the background
-        if: ${{ steps.changed_files.outputs.filtered_changed_files }}
+        if: steps.changed_files.outputs.any_modified == 'true'
         run: npm start > /tmp/stdout.log 2> /tmp/stderr.log &
 
       - name: Run readability analysis
-        if: ${{ steps.changed_files.outputs.filtered_changed_files }}
+        if: steps.changed_files.outputs.any_modified == 'true'
         env:
-          CHANGED_FILES: ${{ steps.changed_files.outputs.filtered_changed_files }}
+          CHANGED_FILES: ${{ steps.changed_files.outputs.all_modified_files }}
         run: npm run readability-report
 
       - name: Find existing readability comment
-        if: ${{ steps.changed_files.outputs.filtered_changed_files }}
+        if: steps.changed_files.outputs.any_modified == 'true'
         uses: peter-evans/find-comment@b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad
         id: findComment
         with:
@@ -77,7 +75,7 @@ jobs:
           body-includes: '<!-- READABILITY_REPORT -->'
 
       - name: Read readability report
-        if: ${{ steps.changed_files.outputs.filtered_changed_files }}
+        if: steps.changed_files.outputs.any_modified == 'true'
         id: read_report
         run: |
           if [ -f "readability-report.md" ]; then
@@ -89,7 +87,7 @@ jobs:
           fi
 
       - name: Create or update readability comment
-        if: ${{ steps.changed_files.outputs.filtered_changed_files && steps.read_report.outputs.report }}
+        if: steps.changed_files.outputs.any_modified == 'true' && steps.read_report.outputs.report
         uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9
         with:
           comment-id: ${{ steps.findComment.outputs.comment-id }}

.github/workflows/link-check-on-pr.yml

@@ -36,20 +36,20 @@ jobs:
 
       - name: Get changed files
         id: changed_files
-        uses: ./.github/actions/get-changed-files
+        uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323 # v47.0.5
         with:
           files: 'content/**'
 
       - name: Set up Node and dependencies
-        if: steps.changed_files.outputs.filtered_changed_files
+        if: steps.changed_files.outputs.any_modified == 'true'
         uses: ./.github/actions/node-npm-setup
 
       - name: Check content type
-        if: steps.changed_files.outputs.filtered_changed_files
+        if: steps.changed_files.outputs.any_modified == 'true'
         id: checkContentType
         run: npm run check-content-type
         env:
-          CHANGED_FILE_PATHS: ${{ steps.changed_files.outputs.filtered_changed_files }}
+          CHANGED_FILE_PATHS: ${{ steps.changed_files.outputs.all_modified_files }}
           CONTENT_TYPE: 'rai'
 
       - name: Add legal as a reviewer

.github/workflows/readability.yml

@@ -43,12 +43,12 @@ jobs:
 
       - name: Get changed files
         id: changed_files
-        uses: ./.github/actions/get-changed-files
+        uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323 # v47.0.5
         with:
           files: 'content/**'
 
       - name: Run tests
         env:
-          CHANGED_FILES: ${{ steps.changed_files.outputs.filtered_changed_files }}
-          DELETED_FILES: ${{ steps.changed_files.outputs.filtered_deleted_files }}
+          CHANGED_FILES: ${{ steps.changed_files.outputs.all_modified_files }}
+          DELETED_FILES: ${{ steps.changed_files.outputs.deleted_files }}
         run: npm test -- src/content-render/tests/render-changed-and-deleted-files.ts

.github/workflows/reviewers-legal.yml

@@ -126,10 +126,12 @@ jobs:
 
       - name: Gather files changed
         if: ${{ matrix.name == 'content-linter' }}
-        uses: ./.github/actions/get-changed-files
-        with:
-          head: ${{ github.event.pull_request.head.ref || github.event.merge_group.head_ref }}
-          output_file: get_diff_files.txt
+        id: changed_files
+        uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323 # v47.0.5
+
+      - name: Write changed files to diff file
+        if: ${{ matrix.name == 'content-linter' }}
+        run: echo "${{ steps.changed_files.outputs.all_modified_files }}" > get_diff_files.txt
 
       - uses: ./.github/actions/cache-nextjs