remove journey article nav components (#58124)

Author: rsese

src/fixtures/tests/playwright-rendering.spec.ts

@@ -1138,22 +1138,6 @@ test.describe('Journey Tracks', () => {
     expect(trackContent).not.toContain('{%')
     expect(trackContent).not.toContain('%}')
   })
-
-  test('journey navigation components show on article pages', async ({ page }) => {
-    // go to an article that's part of a journey track
-    await page.goto('/get-started/start-your-journey/hello-world?feature=journey-navigation')
-
-    // journey next/prev nav components should rende
-    const journeyCard = page.locator('[data-testid="journey-track-card"]')
-    if (await journeyCard.isVisible()) {
-      await expect(journeyCard).toBeVisible()
-    }
-
-    const journeyNav = page.locator('[data-testid="journey-track-nav"]')
-    if (await journeyNav.isVisible()) {
-      await expect(journeyNav).toBeVisible()
-    }
-  })
 })
 
 test.describe('LandingArticleGridWithFilter component', () => {

src/frame/components/article/ArticlePage.tsx

@@ -7,8 +7,6 @@ import { DefaultLayout } from '@/frame/components/DefaultLayout'
 import { ArticleTitle } from '@/frame/components/article/ArticleTitle'
 import { useArticleContext } from '@/frame/components/context/ArticleContext'
 import { LearningTrackNav } from '@/learning-track/components/article/LearningTrackNav'
-import { JourneyTrackNav } from '@/journeys/components/JourneyTrackNav'
-import { JourneyTrackCard } from '@/journeys/components/JourneyTrackCard'
 import { MarkdownContent } from '@/frame/components/ui/MarkdownContent'
 import { Lead } from '@/frame/components/ui/Lead'
 import { PermissionsStatement } from '@/frame/components/ui/PermissionsStatement'
@@ -44,14 +42,10 @@ export const ArticlePage = () => {
     productVideoUrl,
     miniTocItems,
     currentLearningTrack,
-    currentJourneyTrack,
     supportPortalVaIframeProps,
     currentLayout,
   } = useArticleContext()
   const isLearningPath = !!currentLearningTrack?.trackName
-  const isJourneyPath = !!currentJourneyTrack?.trackId
-  // Only show journey track components when feature flag is enabled
-  const showJourneyTracks = isJourneyPath && router.query?.feature === 'journey-navigation'
   const { t } = useTranslation(['pages'])
 
   const introProp = (
@@ -78,7 +72,6 @@ export const ArticlePage = () => {
   const toc = (
     <>
       {isLearningPath && <LearningTrackCard track={currentLearningTrack} />}
-      {showJourneyTracks && <JourneyTrackCard journey={currentJourneyTrack} />}
       {miniTocItems.length > 1 && <MiniTocs miniTocItems={miniTocItems} />}
     </>
   )
@@ -129,11 +122,6 @@ export const ArticlePage = () => {
               <LearningTrackNav track={currentLearningTrack} />
             </div>
           ) : null}
-          {showJourneyTracks ? (
-            <div className="container-lg mt-4 px-3">
-              <JourneyTrackNav context={currentJourneyTrack} />
-            </div>
-          ) : null}
         </>
       ) : (
         <div className="container-xl px-3 px-md-6 my-4">
@@ -160,12 +148,6 @@ export const ArticlePage = () => {
               <LearningTrackNav track={currentLearningTrack} />
             </div>
           ) : null}
-
-          {showJourneyTracks ? (
-            <div className="mt-4">
-              <JourneyTrackNav context={currentJourneyTrack} />
-            </div>
-          ) : null}
         </div>
       )}
     </DefaultLayout>

src/journeys/lib/journey-path-resolver.ts

@@ -83,24 +83,6 @@ function normalizeGuidePath(path: string): string {
     : `/${withoutLanguage || path}`
 }
 
-/**
- * Helper function to append the journey-navigation feature flag to URLs
- */
-function appendJourneyFeatureFlag(href: string): string {
-  if (!href) return href
-
-  try {
-    // we have to pass some URL here, we just throw it away though
-    const url = new URL(href, 'https://docs.github.com')
-    url.searchParams.set('feature', 'journey-navigation')
-    return url.pathname + url.search
-  } catch {
-    // fallback if URL parsing fails
-    const separator = href.includes('?') ? '&' : '?'
-    return `${href}${separator}feature=journey-navigation`
-  }
-}
-
 /**
  * Resolves the journey context for a given article path.
  *
@@ -189,7 +171,7 @@ export async function resolveJourneyContext(
             if (resultData && resultData.length > 0) {
               const linkResult = resultData[0]
               result.prevGuide = {
-                href: appendJourneyFeatureFlag(linkResult.href),
+                href: linkResult.href,
                 title: linkResult.title || '',
               }
             }
@@ -210,7 +192,7 @@ export async function resolveJourneyContext(
             if (resultData && resultData.length > 0) {
               const linkResult = resultData[0]
               result.nextGuide = {
-                href: appendJourneyFeatureFlag(linkResult.href),
+                href: linkResult.href,
                 title: linkResult.title || '',
               }
             }
@@ -251,7 +233,7 @@ export async function resolveJourneyTracks(
           const linkData = await getLinkData(guidePath, context, { title: true })
           const baseHref = linkData?.[0]?.href || guidePath
           return {
-            href: appendJourneyFeatureFlag(baseHref),
+            href: baseHref,
             title: linkData?.[0]?.title || 'Untitled Guide',
           }
         }),

src/journeys/tests/journey-path-resolver.ts

@@ -82,7 +82,7 @@ describe('journey-path-resolver', () => {
       )
 
       expect(result?.prevGuide).toEqual({
-        href: '/en/enterprise-cloud@latest/enterprise-onboarding/setup?feature=journey-navigation',
+        href: '/en/enterprise-cloud@latest/enterprise-onboarding/setup',
         title: 'Mock Title for /enterprise-onboarding/setup',
       })
     })
@@ -95,7 +95,7 @@ describe('journey-path-resolver', () => {
       )
 
       expect(result?.nextGuide).toEqual({
-        href: '/en/enterprise-cloud@latest/enterprise-onboarding/deploy?feature=journey-navigation',
+        href: '/en/enterprise-cloud@latest/enterprise-onboarding/deploy',
         title: 'Mock Title for /enterprise-onboarding/deploy',
       })
     })
@@ -184,7 +184,7 @@ describe('journey-path-resolver', () => {
 
       expect(result[0].guides).toHaveLength(2)
       expect(result[0].guides[0]).toEqual({
-        href: '/en/enterprise-cloud@latest/enterprise-onboarding/setup?feature=journey-navigation',
+        href: '/en/enterprise-cloud@latest/enterprise-onboarding/setup',
         title: 'Mock Title for /enterprise-onboarding/setup',
       })
     })