Merge pull request #19175 from github/remove-check-dep

Use eslint for dependency checks

Author: mikesurowiec

.eslintrc.js

@@ -14,6 +14,7 @@ module.exports = {
     ecmaVersion: 11
   },
   rules: {
+    'import/no-extraneous-dependencies': ['error']
   },
   overrides: [
     {

.github/workflows/js-lint.yml

@@ -41,6 +41,3 @@ jobs:
 
       - name: Run linter
         run: npx eslint .
-
-      - name: Check dependencies
-        run: npm run check-deps

package-lock.json

@@ -126,7 +126,6 @@
     "csv-parser": "^2.3.3",
     "dedent": "^0.7.0",
     "del": "^4.1.1",
-    "dependency-check": "^4.1.0",
     "domwaiter": "^1.1.0",
     "eslint": "^7.13.0",
     "eslint-config-standard": "^16.0.1",
@@ -182,7 +181,7 @@
     "lint": "eslint --fix . && prettier -w \"**/*.{yml,yaml}\" && npm run lint-tsc",
     "lint-translation": "TEST_TRANSLATION=true jest content/lint-files",
     "lint-tsc": "prettier -w \"**/*.{ts,tsx}\"",
-    "test": "jest && eslint . && prettier -c \"**/*.{yml,yaml}\" && npm run check-deps",
+    "test": "jest && eslint . && prettier -c \"**/*.{yml,yaml}\"",
     "prebrowser-test": "npm run build",
     "browser-test": "start-server-and-test browser-test-server 4001 browser-test-tests",
     "browser-test-server": "cross-env NODE_ENV=production PORT=4001 node server.js",
@@ -192,7 +191,6 @@
     "sync-search-server": "cross-env NODE_ENV=production PORT=4002 node server.js",
     "sync-search-indices": "script/sync-search-indices.js",
     "test-watch": "jest --watch --notify --notifyMode=change --coverage",
-    "check-deps": "node script/check-deps.js",
     "prevent-pushes-to-main": "node script/prevent-pushes-to-main.js",
     "pa11y-ci": "pa11y-ci",
     "pa11y-test": "start-server-and-test browser-test-server 4001 pa11y-ci",