Skip to content

Commit 0fadb33

Browse files
authored
Apply suggestions from code review
1 parent c60a2fa commit 0fadb33

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

data/release-notes/enterprise-server/3-0/20.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ sections:
55
bugs:
66
- Pre-receive hooks would fail due to undefined `PATH`.
77
- Running `ghe-repl-setup` would return an error like `cannot create directory /data/user/elasticsearch:File exists` if the instance had previously been configured as a replica.
8-
- In large GHES Cluster environments, the authentication backend could be unavailable on a subset of frontend nodes.
8+
- In large cluster environments, the authentication backend could be unavailable on a subset of frontend nodes.
99
- Some critical services may not have been available on backend nodes in GHES Cluster.
1010
changes:
1111
- An additional outer layer of `gzip` compression when creating a cluster support bundle with `ghe-cluster-suport-bundle` is now turned off by default. This outer compression can optionally be applied with the `ghe-cluster-suport-bundle -c` command line option.
12-
- Upgrade collectd to latest version 5.12.0.
13-
- We have added extra text to the admin console to remind users about the mobile apps'' data collection for experience improvement purposes.
12+
- Upgraded collectd to version 5.12.0.
13+
- We have added extra text to the admin console to remind users about the mobile apps' data collection for experience improvement purposes.
1414
known_issues:
1515
- On a freshly set up {% data variables.product.prodname_ghe_server %} without any users, an attacker could create the first admin user.
1616
- Custom firewall rules are removed during the upgrade process.

data/release-notes/enterprise-server/3-1/12.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ sections:
77
- Pre-receive hooks would fail due to undefined `PATH`.
88
- Running `ghe-repl-setup` would return an error like `cannot create directory /data/user/elasticsearch:File exists` if the instance had previously been configured as a replica.
99
- After setting up a high availability replica, `ghe-repl-status` included an error in the output like `unexpected unclosed action in command`.
10-
- In large GHES Cluster environments, the authentication backend could be unavailable on a subset of frontend nodes.
10+
- In large cluster environments, the authentication backend could be unavailable on a subset of frontend nodes.
1111
- Some critical services may not have been available on backend nodes in GHES Cluster.
1212
changes:
1313
- An additional outer layer of `gzip` compression when creating a cluster support bundle with `ghe-cluster-suport-bundle` is now turned off by default. This outer compression can optionally be applied with the `ghe-cluster-suport-bundle -c` command line option.
14-
- Upgrade collectd to latest version 5.12.0.
15-
- We have added extra text to the admin console to remind users about the mobile apps'' data collection for experience improvement purposes.
14+
- Upgraded collectd to version 5.12.0.
15+
- We have added extra text to the admin console to remind users about the mobile apps' data collection for experience improvement purposes.
1616
known_issues:
1717
- The {% data variables.product.prodname_registry %} npm registry no longer returns a time value in metadata responses. This was done to allow for substantial performance improvements. We continue to have all the data necessary to return a time value as part of the metadata response and will resume returning this value in the future once we have solved the existing performance issues.
1818
- On a freshly set up {% data variables.product.prodname_ghe_server %} without any users, an attacker could create the first admin user.

data/release-notes/enterprise-server/3-2/4.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,16 @@ sections:
88
- Running `ghe-repl-setup` would return an error like `cannot create directory /data/user/elasticsearch:File exists` if the instance had previously been configured as a replica.
99
- Running `ghe-support-bundle` returned an error like `integer expression expected`.
1010
- After setting up a high availability replica, `ghe-repl-status` included an error in the output like `unexpected unclosed action in command`.
11-
- In large GHES Cluster environments, the authentication backend could be unavailable on a subset of frontend nodes.
11+
- In large cluster environments, the authentication backend could be unavailable on a subset of frontend nodes.
1212
- Some critical services may not have been available on backend nodes in GHES Cluster.
1313
- The repository permissions to the user returned by the `/repos` API would not return the full list.
1414
- The `childTeams` connection on the `Team` object in the GraphQL schema produced incorrect results under some circumstances.
1515
- In a high availability configuration, repository maintenance always showed up as failed in stafftools, even when it succeeded.
1616
- User defined patterns would not detect secrets in files like `package.json` or `yarn.lock`.
1717
changes:
1818
- An additional outer layer of `gzip` compression when creating a cluster support bundle with `ghe-cluster-suport-bundle` is now turned off by default. This outer compression can optionally be applied with the `ghe-cluster-suport-bundle -c` command line option.
19-
- Upgrade collectd to latest version 5.12.0.
20-
- We have added extra text to the admin console to remind users about the mobile apps'' data collection for experience improvement purposes.
19+
- Upgraded collectd to version 5.12.0.
20+
- We have added extra text to the admin console to remind users about the mobile apps' data collection for experience improvement purposes.
2121
known_issues:
2222
- On a freshly set up {% data variables.product.prodname_ghe_server %} without any users, an attacker could create the first admin user.
2323
- Custom firewall rules are removed during the upgrade process.

0 commit comments

Comments
 (0)