use Promise.all() on iterator of async functions (#23520)

Author: Peter Bengtsson

script/rendered-content-link-checker.mjs

@@ -186,75 +186,81 @@ function getPages(pageList, languages, filters, files, max) {
 }
 
 async function processPage(page, pageMap, redirects, opts) {
-  const { bail, level, verboseUrl, checkAnchors, checkImages } = opts
-  const allFlaws = []
-
-  for (const permalink of page.permalinks) {
-    const html = await renderInnerHTML(page, permalink)
-    const $ = cheerio.load(html)
-    const flaws = []
-    $('a[href]').each((i, link) => {
-      const { href } = link.attribs
-
-      // The global cache can't be used for anchor links because they
-      // depend on each page it renders
-      if (!href.startsWith('#')) {
-        if (globalHrefCheckCache.has(href)) {
-          globalCacheHitCount++
-          return globalHrefCheckCache.get(href)
-        }
-        globalCacheMissCount++
-      }
+  const { bail, verboseUrl } = opts
 
-      const flaw = checkHrefLink(href, $, redirects, pageMap, checkAnchors)
+  const allFlawsEach = await Promise.all(
+    page.permalinks.map((permalink) => processPermalink(permalink, page, pageMap, redirects, opts))
+  )
 
-      // Again if it's *not* an anchor link, we can use the cache.
-      if (!href.startsWith('#')) {
-        globalHrefCheckCache.set(href, flaw)
-      }
+  const allFlaws = allFlawsEach.flat()
 
-      if (flaw) {
-        if (level === 'critical' && !flaw.CRITICAL) {
-          return
-        }
-        const text = $(link).text()
-        flaws.push({ permalink, page, href, flaw, text })
-      }
-    })
+  if (bail && allFlaws.length > 0) {
+    printFlaws(allFlaws, verboseUrl)
+    process.exit(1)
+  }
 
-    if (checkImages) {
-      $('img[src]').each((i, img) => {
-        const { src } = img.attribs
+  printFlaws(allFlaws, verboseUrl)
 
-        if (globalImageSrcCheckCache.has(src)) {
-          globalCacheHitCount++
-          return globalImageSrcCheckCache.get(src)
-        }
+  return allFlaws
+}
 
-        const flaw = checkImageSrc(src, $)
+async function processPermalink(permalink, page, pageMap, redirects, opts) {
+  const { level, checkAnchors, checkImages } = opts
+  const html = await renderInnerHTML(page, permalink)
+  const $ = cheerio.load(html)
+  const flaws = []
+  $('a[href]').each((i, link) => {
+    const { href } = link.attribs
+
+    // The global cache can't be used for anchor links because they
+    // depend on each page it renders
+    if (!href.startsWith('#')) {
+      if (globalHrefCheckCache.has(href)) {
+        globalCacheHitCount++
+        return globalHrefCheckCache.get(href)
+      }
+      globalCacheMissCount++
+    }
 
-        globalImageSrcCheckCache.set(src, flaw)
+    const flaw = checkHrefLink(href, $, redirects, pageMap, checkAnchors)
 
-        if (flaw) {
-          if (level === 'critical' && !flaw.CRITICAL) {
-            return
-          }
-          flaws.push({ permalink, page, src, flaw })
-        }
-      })
+    // Again if it's *not* an anchor link, we can use the cache.
+    if (!href.startsWith('#')) {
+      globalHrefCheckCache.set(href, flaw)
     }
 
-    if (bail && flaws.length > 0) {
-      printFlaws(flaws, verboseUrl)
-      process.exit(1)
+    if (flaw) {
+      if (level === 'critical' && !flaw.CRITICAL) {
+        return
+      }
+      const text = $(link).text()
+      flaws.push({ permalink, page, href, flaw, text })
     }
+  })
 
-    allFlaws.push(...flaws)
-  }
+  if (checkImages) {
+    $('img[src]').each((i, img) => {
+      const { src } = img.attribs
 
-  printFlaws(allFlaws, verboseUrl)
+      if (globalImageSrcCheckCache.has(src)) {
+        globalCacheHitCount++
+        return globalImageSrcCheckCache.get(src)
+      }
 
-  return allFlaws
+      const flaw = checkImageSrc(src, $)
+
+      globalImageSrcCheckCache.set(src, flaw)
+
+      if (flaw) {
+        if (level === 'critical' && !flaw.CRITICAL) {
+          return
+        }
+        flaws.push({ permalink, page, src, flaw })
+      }
+    })
+  }
+
+  return flaws
 }
 
 function printFlaws(flaws, verboseUrl = null) {