set index-url from url (#1522)

Author: jakecoffman

__tests__/updater.test.ts

@@ -244,6 +244,36 @@ describe('Updater', () => {
     })
   })
 
+  describe('when given python credentials with a URL and not an index-url', () => {
+    const jobDetails = {...mockJobDetails}
+
+    new Updater(
+      'MOCK_UPDATER_IMAGE_NAME',
+      'MOCK_PROXY_IMAGE_NAME',
+      mockApiClient,
+      jobDetails,
+      [
+        {
+          type: 'python_index',
+          url: 'https://example.com/some/path',
+          username: 'user',
+          token: 'token'
+        }
+      ],
+      workingDirectory
+    )
+
+    it('generates credentials metadata with the index from the URL', () => {
+      expect(jobDetails['credentials-metadata']).toEqual([
+        {
+          'index-url': 'https://example.com/some/path',
+          type: 'python_index',
+          url: 'https://example.com/some/path'
+        }
+      ])
+    })
+  })
+
   describe('when given composer credentials with a URL and not a registry', () => {
     const jobDetails = {...mockJobDetails}
 

dist/main/index.js

@@ -80,6 +80,7 @@ export class Updater {
       if (credential['index-url'] !== undefined) {
         obj['index-url'] = credential['index-url']
       }
+      this.setIndexUrlFromUrl(obj, credential)
       if (credential['env-key'] !== undefined) {
         obj['env-key'] = credential['env-key']
       }
@@ -125,6 +126,23 @@ export class Updater {
     }
   }
 
+  private setIndexUrlFromUrl(obj: Credential, credential: Credential): void {
+    if (credential.type !== 'python_index') {
+      return
+    }
+    if (credential['index-url']) {
+      return
+    }
+    if (credential.url) {
+      try {
+        obj['index-url'] = credential.url
+      } catch {
+        // If the URL is invalid, we skip setting the index-url
+        // as it will fall back to the default index URL for pip.
+      }
+    }
+  }
+
   private async runUpdate(proxy: Proxy): Promise<void> {
     const name = `dependabot-job-${this.apiClient.params.jobId}`
     const container = await this.createContainer(proxy, name, {