From 79453cc10310dccc74c0e38c4b2facb4928fe939 Mon Sep 17 00:00:00 2001
From: Owen Mansel-Chan <owen-mc@github.com>
Date: Thu, 22 May 2025 14:30:32 +0100
Subject: [PATCH] Add test showing correct usage

---
 java/ql/src/Performance/StringReplaceAllWithNonRegex.md         | 1 +
 java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java | 1 +
 2 files changed, 2 insertions(+)

diff --git a/java/ql/src/Performance/StringReplaceAllWithNonRegex.md b/java/ql/src/Performance/StringReplaceAllWithNonRegex.md
index 6e298b4955b6..c7bb609b2c02 100644
--- a/java/ql/src/Performance/StringReplaceAllWithNonRegex.md
+++ b/java/ql/src/Performance/StringReplaceAllWithNonRegex.md
@@ -18,6 +18,7 @@ public class Test {
         String s1 = "test";
         s1 = s1.replaceAll("t", "x"); // NON_COMPLIANT
         s1 = s1.replaceAll(".*", "x"); // COMPLIANT
+        s1 = s1.replace("t", "x"); // COMPLIANT
     }
 }
 
diff --git a/java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java b/java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java
index 1465343b8c2e..86711c93de51 100644
--- a/java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java
+++ b/java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java
@@ -3,5 +3,6 @@ void f() {
         String s1 = "test";
         s1 = s1.replaceAll("t", "x"); // $ Alert // NON_COMPLIANT
         s1 = s1.replaceAll(".*", "x"); // COMPLIANT
+        s1 = s1.replace("t", "x"); // COMPLIANT
     }
 }