C++: Fix ql-for-ql warning

jketema · jketema · commit fc7334af75c0 · 2024-12-10T20:29:25.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedCall.qll b/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedCall.qll
@@ -364,7 +364,7 @@ class TranslatedFunctionCall extends TranslatedCallExpr, TranslatedDirectCall {
   final override predicate mayThrowException(ExceptionEdge e) {
     this.mustThrowException(e)
     or
-    exists(MicrosoftTryStmt t | t = expr.getEnclosingStmt().getParentStmt*()) and
+    expr.getEnclosingStmt().getParentStmt*() instanceof MicrosoftTryStmt and
     e instanceof SehExceptionEdge
   }
 

Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ class TranslatedFunctionCall extends TranslatedCallExpr, TranslatedDirectCall {`
`364`	`364`	`final override predicate mayThrowException(ExceptionEdge e) {`
`365`	`365`	`this.mustThrowException(e)`
`366`	`366`	`or`
`367`		`- exists(MicrosoftTryStmt t \| t = expr.getEnclosingStmt().getParentStmt*()) and`
	`367`	`+ expr.getEnclosingStmt().getParentStmt*() instanceof MicrosoftTryStmt and`
`368`	`368`	`e instanceof SehExceptionEdge`
`369`	`369`	`}`
`370`	`370`