JS: Fix some uses of deprecated predicates

Author: asgerf

javascript/ql/test/library-tests/JSDoc/NameResolution/test.expected

@@ -1,4 +1,3 @@
-WARNING: predicate 'hasQualifiedName' has been deprecated and may be removed in future (test.ql:3,68-84)
 | bar.js:5:14:5:14 | x | ns.very.long.namespace |
 | bar.js:5:14:5:18 | x.Foo | ns.very.long.namespace.Foo |
 | bar.js:12:14:12:17 | iife | IIFE |

javascript/ql/test/library-tests/JSDoc/NameResolution/test.ql

@@ -1,3 +1,3 @@
 import javascript
 
-query string test_hasQualifiedName(JSDocNamedTypeExpr expr) { expr.hasQualifiedName(result) }
+query string test_hasUnderlyingType(JSDocNamedTypeExpr expr) { expr.hasUnderlyingType(result) }

javascript/ql/test/library-tests/TypeAnnotations/JSDoc/JSDocTypeAnnotations.expected

@@ -1,9 +1,8 @@
-WARNING: predicate 'hasQualifiedName' has been deprecated and may be removed in future (JSDocTypeAnnotations.ql:7,63-79)
 test_isString
 | tst.js:2:12:2:17 | string |
 test_isNumber
 | tst.js:3:12:3:17 | number |
-test_QualifiedName
+test_hasUnderlyingType
 | VarType | tst.js:9:13:9:19 | VarType |
 | boolean | tst.js:5:14:5:20 | boolean |
 | foo | tst.js:4:12:4:14 | foo |

javascript/ql/test/library-tests/TypeAnnotations/JSDoc/JSDocTypeAnnotations.ql

@@ -4,7 +4,7 @@ query TypeAnnotation test_isString() { result.isString() }
 
 query TypeAnnotation test_isNumber() { result.isNumber() }
 
-query TypeAnnotation test_QualifiedName(string name) { result.hasQualifiedName(name) }
+query TypeAnnotation test_hasUnderlyingType(string name) { result.hasUnderlyingType(name) }
 
 query TypeAnnotation test_ParameterType(Parameter p) { result = p.getTypeAnnotation() }
 

javascript/ql/test/library-tests/TypeAnnotations/TSUnresolvedQualifiedName/QualifiedNames.expected

@@ -1,3 +1,2 @@
-WARNING: predicate 'hasQualifiedName' has been deprecated and may be removed in future (QualifiedNames.ql:4,12-28)
 | tst.ts:4:8:4:21 | UnresolvedType | unresolved | UnresolvedType |
 | tst.ts:5:8:5:19 | ResolvedType | resolved | ResolvedType |

javascript/ql/test/library-tests/TypeAnnotations/TSUnresolvedQualifiedName/QualifiedNames.ql

@@ -1,5 +1,5 @@
 import javascript
 
 from TypeAnnotation type, string mod, string name
-where type.hasQualifiedName(mod, name)
+where type.hasUnderlyingType(mod, name)
 select type, mod, name

javascript/ql/test/library-tests/TypeScript/HasQualifiedNameFallback/Test.expected

@@ -1,7 +1,4 @@
-WARNING: predicate 'hasQualifiedName' has been deprecated and may be removed in future (Test.ql:4,10-26)
-WARNING: predicate 'hasQualifiedName' has been deprecated and may be removed in future (Test.ql:8,10-26)
-WARNING: predicate 'hasQualifiedName' has been deprecated and may be removed in future (Test.ql:12,30-46)
-hasQualifiedNameModule
+hasUnderlyingTypeModule
 | default-import |  | tst.ts:11:9:11:21 | DefaultImport |
 | global | UnresolvedName | tst.ts:12:9:12:22 | UnresolvedName |
 | import-assign |  | tst.ts:10:9:10:11 | asn |
@@ -12,7 +9,7 @@ hasQualifiedNameModule
 | named-import | Name2 | tst.ts:8:9:8:13 | Name2 |
 | namespace-import |  | tst.ts:9:9:9:17 | namespace |
 | namespace-import | Foo | tst.ts:9:9:9:21 | namespace.Foo |
-hasQualifiedNameGlobal
+hasUnderlyingTypeGlobal
 | UnresolvedName | tst.ts:12:9:12:22 | UnresolvedName |
 paramExample
 | tst.ts:7:5:7:6 | x1 |

javascript/ql/test/library-tests/TypeScript/HasQualifiedNameFallback/Test.ql

@@ -1,13 +1,13 @@
 import javascript
 
-query TypeAnnotation hasQualifiedNameModule(string moduleName, string member) {
-  result.hasQualifiedName(moduleName, member)
+query TypeAnnotation hasUnderlyingTypeModule(string moduleName, string member) {
+  result.hasUnderlyingType(moduleName, member)
 }
 
-query TypeAnnotation hasQualifiedNameGlobal(string globalName) {
-  result.hasQualifiedName(globalName)
+query TypeAnnotation hasUnderlyingTypeGlobal(string globalName) {
+  result.hasUnderlyingType(globalName)
 }
 
 query Parameter paramExample() {
-  result.getTypeAnnotation().hasQualifiedName("named-import", "Name1")
+  result.getTypeAnnotation().hasUnderlyingType("named-import", "Name1")
 }