Skip to content

Commit 4673941

Browse files
authored
Merge branch 'main' into fix/path-injection-read-subkind
2 parents 49e5886 + 04a8ef0 commit 4673941

46 files changed

Lines changed: 1824 additions & 658 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

cpp/ql/src/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* The "Multiplication result converted to larger type" (`cpp/integer-multiplication-cast-to-long`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
88
* The "Suspicious add with sizeof" (`cpp/suspicious-add-sizeof`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
99
* The "Wrong type of arguments to formatting function" (`cpp/wrong-type-format-argument`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
10-
* The "Implicit function declaration" (`cpp/implicit-function-declaration`) query has been upgraded to `high` precision. However, for `build mode: none` databases, it no longer produces any results. The results in this mode were found to be very noisy and fundamentally imprecise.
10+
* The "Implicit function declaration" (`cpp/implicit-function-declaration`) query has been upgraded to `high` precision. However, for `build-mode: none` databases, it no longer produces any results. The results in this mode were found to be very noisy and fundamentally imprecise.
1111

1212
## 1.6.0
1313

cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFunctionDeclaration.qhelp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function may behave unpredictably.</p>
1414
<p>This may indicate a misspelled function name, or that the required header containing
1515
the function declaration has not been included.</p>
1616

17-
<p>Note: This query is not compatible with <code>build mode: none</code> databases, and produces
17+
<p>Note: This query is not compatible with <code>build-mode: none</code> databases, and produces
1818
no results on those databases.</p>
1919

2020
</overview>

cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFunctionDeclaration.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import TooManyArguments
1818
import semmle.code.cpp.commons.Exclusions
1919

2020
/*
21-
* This query is not compatible with build mode: none databases, and produces
21+
* This query is not compatible with build-mode: none databases, and produces
2222
* no results on those databases.
2323
*/
2424

cpp/ql/src/change-notes/released/1.6.1.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@
77
* The "Multiplication result converted to larger type" (`cpp/integer-multiplication-cast-to-long`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
88
* The "Suspicious add with sizeof" (`cpp/suspicious-add-sizeof`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
99
* The "Wrong type of arguments to formatting function" (`cpp/wrong-type-format-argument`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
10-
* The "Implicit function declaration" (`cpp/implicit-function-declaration`) query has been upgraded to `high` precision. However, for `build mode: none` databases, it no longer produces any results. The results in this mode were found to be very noisy and fundamentally imprecise.
10+
* The "Implicit function declaration" (`cpp/implicit-function-declaration`) query has been upgraded to `high` precision. However, for `build-mode: none` databases, it no longer produces any results. The results in this mode were found to be very noisy and fundamentally imprecise.

csharp/ql/lib/CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@ No user-facing changes.
6464
* When a code-scanning configuration specifies the `paths:` and/or `paths-ignore:` settings, these are now taken into account by the C# extractor's search for `.config`, `.props`, XML and project files.
6565
* Updated the generated .NET “models as data” runtime models to cover .NET 10.
6666
* C# 14: Support for *implicit* span conversions in the QL library.
67-
* Basic extractor support for .NET 10 is now available. Extraction is supported for .NET 10 projects in both traced mode and `build mode: none`. However, code that uses language features new to C# 14 is not yet fully supported for extraction and analysis.
67+
* Basic extractor support for .NET 10 is now available. Extraction is supported for .NET 10 projects in both traced mode and `build-mode: none`. However, code that uses language features new to C# 14 is not yet fully supported for extraction and analysis.
6868
* Added autobuilder and `build-mode: none` support for `.slnx` solution files.
69-
* In `build mode: none`, .NET 10 is now used by default unless a specific .NET version is specified elsewhere.
69+
* In `build-mode: none`, .NET 10 is now used by default unless a specific .NET version is specified elsewhere.
7070
* Added implicit reads of `System.Collections.Generic.KeyValuePair.Value` at taint-tracking sinks and at inputs to additional taint steps. As a result, taint-tracking queries will now produce more results when a container is tainted.
7171

7272
### Bug Fixes

csharp/ql/lib/change-notes/released/5.4.5.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
* When a code-scanning configuration specifies the `paths:` and/or `paths-ignore:` settings, these are now taken into account by the C# extractor's search for `.config`, `.props`, XML and project files.
66
* Updated the generated .NET “models as data” runtime models to cover .NET 10.
77
* C# 14: Support for *implicit* span conversions in the QL library.
8-
* Basic extractor support for .NET 10 is now available. Extraction is supported for .NET 10 projects in both traced mode and `build mode: none`. However, code that uses language features new to C# 14 is not yet fully supported for extraction and analysis.
8+
* Basic extractor support for .NET 10 is now available. Extraction is supported for .NET 10 projects in both traced mode and `build-mode: none`. However, code that uses language features new to C# 14 is not yet fully supported for extraction and analysis.
99
* Added autobuilder and `build-mode: none` support for `.slnx` solution files.
10-
* In `build mode: none`, .NET 10 is now used by default unless a specific .NET version is specified elsewhere.
10+
* In `build-mode: none`, .NET 10 is now used by default unless a specific .NET version is specified elsewhere.
1111
* Added implicit reads of `System.Collections.Generic.KeyValuePair.Value` at taint-tracking sinks and at inputs to additional taint steps. As a result, taint-tracking queries will now produce more results when a container is tainted.
1212

1313
### Bug Fixes

docs/codeql/codeql-overview/codeql-changelog/codeql-cli-2.24.0.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,9 @@ C#
152152
* When a code-scanning configuration specifies the :code:`paths:` and/or :code:`paths-ignore:` settings, these are now taken into account by the C# extractor's search for :code:`.config`, :code:`.props`, XML and project files.
153153
* Updated the generated .NET “models as data” runtime models to cover .NET 10.
154154
* C# 14: Support for *implicit* span conversions in the QL library.
155-
* Basic extractor support for .NET 10 is now available. Extraction is supported for .NET 10 projects in both traced mode and :code:`build mode: none`. However, code that uses language features new to C# 14 is not yet fully supported for extraction and analysis.
155+
* Basic extractor support for .NET 10 is now available. Extraction is supported for .NET 10 projects in both traced mode and :code:`build-mode: none`. However, code that uses language features new to C# 14 is not yet fully supported for extraction and analysis.
156156
* Added autobuilder and :code:`build-mode: none` support for :code:`.slnx` solution files.
157-
* In :code:`build mode: none`, .NET 10 is now used by default unless a specific .NET version is specified elsewhere.
157+
* In :code:`build-mode: none`, .NET 10 is now used by default unless a specific .NET version is specified elsewhere.
158158
* Added implicit reads of :code:`System.Collections.Generic.KeyValuePair.Value` at taint-tracking sinks and at inputs to additional taint steps. As a result, taint-tracking queries will now produce more results when a container is tainted.
159159

160160
Golang
Lines changed: 124 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,124 @@
1+
.. _codeql-cli-2.25.3:
2+
3+
==========================
4+
CodeQL 2.25.3 (2026-05-01)
5+
==========================
6+
7+
.. contents:: Contents
8+
:depth: 2
9+
:local:
10+
:backlinks: none
11+
12+
This is an overview of changes in the CodeQL CLI and relevant CodeQL query and library packs. For additional updates on changes to the CodeQL code scanning experience, check out the `code scanning section on the GitHub blog <https://github.blog/tag/code-scanning/>`__, `relevant GitHub Changelog updates <https://github.blog/changelog/label/application-security/>`__, `changes in the CodeQL extension for Visual Studio Code <https://marketplace.visualstudio.com/items/GitHub.vscode-codeql/changelog>`__, and the `CodeQL Action changelog <https://github.com/github/codeql-action/blob/main/CHANGELOG.md>`__.
13+
14+
Security Coverage
15+
-----------------
16+
17+
CodeQL 2.25.3 runs a total of 496 security queries when configured with the Default suite (covering 169 CWE). The Extended suite enables an additional 131 queries (covering 32 more CWE).
18+
19+
CodeQL CLI
20+
----------
21+
22+
Improvements
23+
~~~~~~~~~~~~
24+
25+
* The :code:`codeql database finalize` command now accepts the :code:`--working-dir` flag. When specified, any extractor pre-finalize scripts will be run in that directory. If the flag is not used, the scripts will run in the source root directory (maintaining existing behavior). The flag will also be automatically passed through when running the higher-level
26+
:code:`codeql database create` command.
27+
28+
Query Packs
29+
-----------
30+
31+
Major Analysis Improvements
32+
~~~~~~~~~~~~~~~~~~~~~~~~~~~
33+
34+
GitHub Actions
35+
""""""""""""""
36+
37+
* Fixed alert messages in :code:`actions/artifact-poisoning/critical` and :code:`actions/artifact-poisoning/medium` as they previously included a redundant placeholder in the alert message that would on occasion contain a long block of yml that makes the alert difficult to understand. Also improved the wording to make it clearer that it is not the artifact that is being poisoned, but instead a potentially untrusted artifact that is consumed. Finally, changed the alert location to be the source, to align more with other queries reporting an artifact (e.g. zipslip) which is more useful.
38+
39+
Minor Analysis Improvements
40+
~~~~~~~~~~~~~~~~~~~~~~~~~~~
41+
42+
C/C++
43+
"""""
44+
45+
* Added :code:`AllocationFunction` models for :code:`aligned_alloc`, :code:`std::aligned_alloc`, and :code:`bsl::aligned_alloc`.
46+
* The "Comparison of narrow type with wide type in loop condition" (:code:`cpp/comparison-with-wider-type`) query has been upgraded to :code:`high` precision. This query will now run in the default code scanning suite.
47+
* The "Multiplication result converted to larger type" (:code:`cpp/integer-multiplication-cast-to-long`) query has been upgraded to :code:`high` precision. This query will now run in the default code scanning suite.
48+
* The "Suspicious add with sizeof" (:code:`cpp/suspicious-add-sizeof`) query has been upgraded to :code:`high` precision. This query will now run in the default code scanning suite.
49+
* The "Wrong type of arguments to formatting function" (:code:`cpp/wrong-type-format-argument`) query has been upgraded to :code:`high` precision. This query will now run in the default code scanning suite.
50+
* The "Implicit function declaration" (:code:`cpp/implicit-function-declaration`) query has been upgraded to :code:`high` precision. However, for :code:`build-mode: none` databases, it no longer produces any results. The results in this mode were found to be very noisy and fundamentally imprecise.
51+
52+
C#
53+
""
54+
55+
* The query :code:`cs/useless-tostring-call` has been updated to avoid false positive results in calls to :code:`StringBuilder.AppendLine` and calls of the form :code:`base.ToString()`. Moreover, the alert message has been made more precise.
56+
57+
JavaScript/TypeScript
58+
"""""""""""""""""""""
59+
60+
* The query :code:`js/missing-rate-limiting` now takes Fastify per-route rate limiting into account.
61+
62+
Python
63+
""""""
64+
65+
* The :code:`py/bind-socket-all-network-interfaces` query now uses the global data-flow library, leading to better precision and more results. Also, wrappers of :code:`socket.socket` in the :code:`eventlet` and :code:`gevent` libraries are now also recognized as socket binding operations.
66+
67+
GitHub Actions
68+
""""""""""""""
69+
70+
* The query :code:`actions/missing-workflow-permissions` no longer produces false positive results on reusable workflows where all callers set permissions.
71+
72+
Language Libraries
73+
------------------
74+
75+
Breaking Changes
76+
~~~~~~~~~~~~~~~~
77+
78+
C/C++
79+
"""""
80+
81+
* The deprecated :code:`NonThrowingFunction` class has been removed, use :code:`NonCppThrowingFunction` instead.
82+
* The deprecated :code:`ThrowingFunction` class has been removed, use :code:`AlwaysSehThrowingFunction` instead.
83+
84+
Major Analysis Improvements
85+
~~~~~~~~~~~~~~~~~~~~~~~~~~~
86+
87+
Swift
88+
"""""
89+
90+
* Upgraded to allow analysis of Swift 6.3.
91+
92+
Minor Analysis Improvements
93+
~~~~~~~~~~~~~~~~~~~~~~~~~~~
94+
95+
Java/Kotlin
96+
"""""""""""
97+
98+
* The queries "Resolving XML external entity in user-controlled data" (:code:`java/xxe`) and "Resolving XML external entity in user-controlled data from local source" (:code:`java/xxe-local`) now recognize sinks in the Woodstox StAX library when :code:`com.ctc.wstx.stax.WstxInputFactory` or :code:`org.codehaus.stax2.XMLInputFactory2` are used directly.
99+
100+
Python
101+
""""""
102+
103+
* The Python extractor now supports the new :code:`lazy import ...` and :code:`lazy from ... import ...` (as defined in `PEP-810 <https://peps.python.org/pep-0810/>`__) that will be part of Python 3.15.
104+
105+
GitHub Actions
106+
""""""""""""""
107+
108+
* Removed false positive injection sink models for the :code:`context` input of :code:`docker/build-push-action` and the :code:`allowed-endpoints` input of :code:`step-security/harden-runner`.
109+
110+
Deprecated APIs
111+
~~~~~~~~~~~~~~~
112+
113+
C#
114+
""
115+
116+
* The predicates :code:`get[L|R]Value` in the class :code:`Assignment` have been deprecated. Use :code:`get[Left|Right]Operand` instead.
117+
118+
New Features
119+
~~~~~~~~~~~~
120+
121+
C/C++
122+
"""""
123+
124+
* Added a subclass :code:`AutoconfConfigureTestFile` of :code:`ConfigurationTestFile` that represents files created by GNU autoconf configure scripts to test the build configuration.

docs/codeql/codeql-overview/codeql-changelog/index.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ A list of queries for each suite and language `is available here <https://docs.g
1111
.. toctree::
1212
:maxdepth: 1
1313

14+
codeql-cli-2.25.3
1415
codeql-cli-2.25.2
1516
codeql-cli-2.25.1
1617
codeql-cli-2.25.0

java/ql/lib/semmle/code/java/Expr.qll

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2732,11 +2732,6 @@ class PatternExpr extends Expr {
27322732
*/
27332733
LocalVariableDeclExpr asBindingOrUnnamedPattern() { result = this }
27342734

2735-
/**
2736-
* DEPRECATED: alias for `asBindingOrUnnamedPattern`.
2737-
*/
2738-
deprecated LocalVariableDeclExpr asBindingPattern() { result = this.asBindingOrUnnamedPattern() }
2739-
27402735
/**
27412736
* Gets this pattern cast to a record pattern.
27422737
*/

0 commit comments

Comments
 (0)