Go: Make installed toolchain version a parameter of hasInvalidToolchainVersion

Author: mbg

go/extractor/project/project.go

@@ -198,7 +198,7 @@ var toolchainVersionRe *regexp.Regexp = regexp.MustCompile(`(?m)^([0-9]+\.[0-9]+
 // Returns true if the `go.mod` file specifies a Go language version which is not of the format that
 // is expected by the Go 1.21 and Go 1.22 toolchains for toolchain versions, and there is no
 // explicit toolchain version declared.
-func hasInvalidToolchainVersion(modFile *modfile.File) bool {
+func hasInvalidToolchainVersion(installedToolchainVersion util.SemVer, modFile *modfile.File) bool {
 	if modFile.Toolchain != nil {
 		// There is an explicit toolchain directive, so it doesn't matter what format the
 		// Go language version is in, since it will not be used as a fallback toolchain version.
@@ -208,8 +208,7 @@ func hasInvalidToolchainVersion(modFile *modfile.File) bool {
 		// does not match the toolchain version format in Go 1.21 and Go 1.22.
 		// This is a problem if the installed Go toolchain is within that version range
 		// as it will try to use the language version as the toolchain version.
-		installed := util.NewSemVer(toolchain.GetEnvGoVersion())
-		return installed.IsAtLeast(toolchain.V1_21) && installed.IsOlderThan(toolchain.V1_23)
+		return installedToolchainVersion.IsAtLeast(toolchain.V1_21) && installedToolchainVersion.IsOlderThan(toolchain.V1_23)
 	}
 	return false
 }
@@ -244,7 +243,7 @@ func LoadGoModules(emitDiagnostics bool, goModFilePaths []string) []*GoModule {
 		// there is no `toolchain` directive, check that it is a valid Go toolchain version. Otherwise,
 		// `go` commands which try to download the right version of the Go toolchain will fail. We detect
 		// this situation and emit a diagnostic.
-		if hasInvalidToolchainVersion(modFile) {
+		if hasInvalidToolchainVersion(util.NewSemVer(toolchain.GetEnvGoVersion()), modFile) {
 			diagnostics.EmitInvalidToolchainVersion(goModFilePath, modFile.Go.Version)
 		}
 	}