Skip to content

Commit 25d232b

Browse files
Copilotowen-mc
andauthored
Model additional Hibernate query sinks
Agent-Logs-Url: https://github.com/github/codeql/sessions/fc2c7f71-3493-4bf7-9136-34571a1d4b47 Co-authored-by: owen-mc <62447351+owen-mc@users.noreply.github.com>
1 parent 081ad03 commit 25d232b

5 files changed

Lines changed: 23 additions & 0 deletions

File tree

java/ql/lib/ext/org.hibernate.query.model.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,8 @@ extensions:
44
extensible: sinkModel
55
data:
66
- ["org.hibernate.query", "QueryProducer", True, "createNativeQuery", "", "", "Argument[0]", "sql-injection", "manual"]
7+
- ["org.hibernate.query", "QueryProducer", True, "createNativeMutationQuery", "", "", "Argument[0]", "sql-injection", "manual"]
78
- ["org.hibernate.query", "QueryProducer", True, "createQuery", "", "", "Argument[0]", "sql-injection", "manual"]
9+
- ["org.hibernate.query", "QueryProducer", True, "createMutationQuery", "", "", "Argument[0]", "sql-injection", "manual"]
10+
- ["org.hibernate.query", "QueryProducer", True, "createSelectionQuery", "", "", "Argument[0]", "sql-injection", "manual"]
811
- ["org.hibernate.query", "QueryProducer", True, "createSQLQuery", "", "", "Argument[0]", "sql-injection", "manual"]

java/ql/test/query-tests/security/CWE-089/semmle/examples/Hibernate.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,11 @@ public static void test(
1515
sharedSessionContract.createSQLQuery(source()); // $ sqlInjection
1616

1717
queryProducer.createNativeQuery(source()); // $ sqlInjection
18+
queryProducer.createNativeMutationQuery(source()); // $ sqlInjection
1819
queryProducer.createQuery(source()); // $ sqlInjection
20+
queryProducer.createMutationQuery(source()); // $ sqlInjection
21+
queryProducer.createSelectionQuery(source()); // $ sqlInjection
22+
queryProducer.createSelectionQuery(source(), Object.class); // $ sqlInjection
1923
queryProducer.createSQLQuery(source()); // $ sqlInjection
2024
}
2125
}

java/ql/test/stubs/hibernate-5.x/org/hibernate/query/MutationQuery.java

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

java/ql/test/stubs/hibernate-5.x/org/hibernate/query/QueryProducer.java

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

java/ql/test/stubs/hibernate-5.x/org/hibernate/query/SelectionQuery.java

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)