Remove defining argument nodes from data-flow graph

Nikita Kraiouchkine · Nikita Kraiouchkine · commit 9dd30f0fe2b0 · 2023-04-07T03:51:48.000+02:00
diff --git a/c/common/src/codingstandards/c/OutOfBounds.qll b/c/common/src/codingstandards/c/OutOfBounds.qll
@@ -949,6 +949,8 @@ module OOB {
       // remove flow from `src` to `dst` in a buffer access function call
       // the standard library models such flow through functions such as memcpy, strcpy, etc.
       exists(BufferAccessLibraryFunctionCall fc | node.asExpr() = fc.getReadArg().getAChild*())
+      or
+      node.asDefiningArgument() instanceof AddressOfExpr
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -949,6 +949,8 @@ module OOB {`
`949`	`949`	// remove flow from `src` to `dst` in a buffer access function call
`950`	`950`	`// the standard library models such flow through functions such as memcpy, strcpy, etc.`
`951`	`951`	`exists(BufferAccessLibraryFunctionCall fc \| node.asExpr() = fc.getReadArg().getAChild*())`
	`952`	`+ or`
	`953`	`+ node.asDefiningArgument() instanceof AddressOfExpr`
`952`	`954`	`}`
`953`	`955`	`}`
`954`	`956`