+ "details": "### Summary\n\nPraisonAI's recipe registry pull flow extracts attacker-controlled `.praison` tar archives with `tar.extractall()` and does not validate archive member paths before extraction. A malicious publisher can upload a recipe bundle that contains `../` traversal entries and any user who later pulls that recipe will write files outside the output directory they selected.\n\nThis is a path traversal / arbitrary file write vulnerability on the client side of the recipe registry workflow. It affects both the local registry pull path and the HTTP registry pull path. The checksum verification does not prevent exploitation because the malicious traversal payload is part of the signed bundle itself.\n\n### Details\n\nThe issue is caused by unsafe extraction of tar archive contents during recipe pull.\n\n1. A malicious publisher creates a valid `.praison` bundle whose `manifest.json` is benign enough to pass publish, but whose tar members include traversal entries such as:\n\n```text\n../../escape-http.txt\n```\n\n2. `LocalRegistry.publish()` in `src/praisonai/praisonai/recipe/registry.py:214-287` only reads `manifest.json`, calculates a checksum, and stores the uploaded bundle. It does not inspect or sanitize the rest of the tar members before saving the archive.\n\n3. When a victim later pulls the recipe from a local registry, `LocalRegistry.pull()` in `src/praisonai/praisonai/recipe/registry.py:289-345` extracts the tarball directly:\n\n```python\nrecipe_dir = output_dir / name\nrecipe_dir.mkdir(parents=True, exist_ok=True)\n\nwith tarfile.open(bundle_path, \"r:gz\") as tar:\n tar.extractall(recipe_dir)\n```\n\n4. The HTTP client path is also vulnerable. `HttpRegistry.pull()` in `src/praisonai/praisonai/recipe/registry.py:691-739` downloads the bundle and then performs the same unsafe extraction:\n\n```python\nrecipe_dir = output_dir / name\nrecipe_dir.mkdir(parents=True, exist_ok=True)\n\nwith tarfile.open(bundle_path, \"r:gz\") as tar:\n tar.extractall(recipe_dir)\n```\n\n5. Because no archive member validation is performed, traversal entries escape `recipe_dir` and create files elsewhere on disk.\n\nVerified vulnerable behavior:\n\n- Published recipe name: `evil-http`\n- Victim-selected output directory: `/tmp/praisonai-pull-traversal-poc/victim-output`\n- Artifact created outside that directory: `/tmp/praisonai-pull-traversal-poc/escape-http.txt`\n- Artifact contents: `owned over http`\n\nThis demonstrates that a remote publisher can cause filesystem writes outside the pull destination chosen by another user.\n\n### PoC\n\nRun the single verification script from the checked-out repository:\n\n```bash\ncd \"/Users/r1zzg0d/Documents/CVE hunting/targets/PraisonAI\"\npython3 tmp/pocs/poc2.py\n```\n\nExpected vulnerable output:\n\n```text\n[+] Publish result: {'ok': True, 'name': 'evil-http', 'version': '1.0.0', ...}\n[+] Pull result: {'name': 'evil-http', 'version': '1.0.0', ...}\n[+] Outside artifact exists: True\n[+] Artifact also inside output dir: False\n[+] Outside artifact content: 'owned over http\\n'\n[+] RESULT: VULNERABLE - pulling the recipe created a file outside the chosen output directory.\n```\n\nThen verify the created file manually:\n\n```bash\nls -l /tmp/praisonai-pull-traversal-poc/escape-http.txt\ncat /tmp/praisonai-pull-traversal-poc/escape-http.txt\nfind /tmp/praisonai-pull-traversal-poc -maxdepth 3 | sort\n```\n\nWhat the script does internally:\n\n1. Starts a local PraisonAI recipe registry server.\n2. Builds a malicious `.praison` bundle containing the tar entry `../../escape-http.txt`.\n3. Publishes the malicious bundle to the local HTTP registry.\n4. Simulates a victim pulling that recipe into `/tmp/praisonai-pull-traversal-poc/victim-output`.\n5. Confirms that the file is created outside the chosen output directory.\n\n### Impact\n\nThis is a path traversal / arbitrary file write vulnerability in the recipe pull workflow.\n\nImpacted parties:\n\n- Users who pull recipes from an untrusted or shared PraisonAI registry.\n- Teams running internal registries where one publisher can influence what other users pull.\n- Automated systems or CI jobs that fetch recipes into working directories near sensitive project files.\n\nSecurity impact:\n\n- Integrity impact is high because an attacker can create or overwrite files outside the expected extraction directory.\n- Availability impact is significant if the overwritten target is a config file, project file, startup script, or another operational artifact.\n- The issue crosses a real security boundary because the attacker only needs to publish a malicious recipe, while the victim triggers the write by pulling it.\n\n### Remediation\n\n1. Replace raw `tar.extractall()` with a safe extraction routine that validates every `TarInfo` member before extraction. Reject absolute paths, `..` segments, and any resolved path that escapes the intended extraction directory.\n\n2. Apply the same archive member validation in both `LocalRegistry.pull()` and `HttpRegistry.pull()` so that local and remote registry clients share the same safety guarantees.\n\n3. Consider validating tar contents during publish as well, so malicious bundles are rejected before they ever enter the registry and cannot be served to downstream users.",
![advisory-database[bot]](https://avatars.githubusercontent.com/in/21409?v=4&size=40){kind=avatar}
0 commit comments