update pluginManager file paths

- add type keyword to type imports
- add comment clarifying test scanner plugin

Author: abdulahmad307

.github/actions/find/src/findForUrl.ts

@@ -3,7 +3,7 @@ import {AxeBuilder} from '@axe-core/playwright'
 import playwright from 'playwright'
 import {AuthContext} from './AuthContext.js'
 import {generateScreenshots} from './generateScreenshots.js'
-import {loadPlugins, invokePlugin} from './pluginManager'
+import {loadPlugins, invokePlugin} from './pluginManager/index.js'
 import {getScansContext} from './scansContextProvider.js'
 import * as core from '@actions/core'
 

.github/actions/find/src/pluginManager/index.ts

@@ -6,7 +6,7 @@ import {
   loadPluginViaJsFile,
   loadPluginViaTsFile,
 } from './pluginFileLoaders.js'
-import {
+import type {
   Plugin,
   PluginDefaultParams
 } from './types.d.js'

.github/actions/find/src/pluginManager/pluginFileLoaders.ts

@@ -3,7 +3,7 @@ import * as path from 'path'
 import * as esbuild from 'esbuild'
 import {dynamicImport} from '../dynamicImport.js'
 import * as core from '@actions/core'
-import { Plugin } from './types.js'
+import type { Plugin } from './types.js'
 
 // - these functions had to be moved into a separate file
 //   because vitest will not mock the implementation of functions
@@ -16,25 +16,29 @@ export async function loadPluginViaTsFile(pluginFolderPath: string): Promise<Plu
     return
   }
 
-  core.info(`index.ts found for plugin at path: ${pluginFolderPath}`)
-  const esbuildResult = await esbuild.build({
-    entryPoints: [pluginEntryPath],
-    write: false,
-    bundle: true,
-    format: 'esm',
-    platform: 'node',
-    target: 'node24',
-    sourcemap: 'inline',
-  })
+  try {
+    core.info(`index.ts found for plugin at path: ${pluginFolderPath}`)
+    const esbuildResult = await esbuild.build({
+      entryPoints: [pluginEntryPath],
+      write: false,
+      bundle: true,
+      format: 'esm',
+      platform: 'node',
+      target: 'node24',
+      sourcemap: 'inline',
+    })
 
-  const outputFileContents = esbuildResult.outputFiles[0]?.text
-  if (!outputFileContents) {
-    core.info(`esbuild produced no output for plugin: ${pluginEntryPath}`)
-    return
-  }
+    const outputFileContents = esbuildResult.outputFiles[0]?.text
+    if (!outputFileContents) {
+      core.info(`esbuild produced no output for plugin: ${pluginEntryPath}`)
+      return
+    }
 
-  const base64CompiledPlugin = Buffer.from(outputFileContents).toString('base64')
-  return dynamicImport(`data:text/javascript;base64,${base64CompiledPlugin}`)
+    const base64CompiledPlugin = Buffer.from(outputFileContents).toString('base64')
+    return dynamicImport(`data:text/javascript;base64,${base64CompiledPlugin}`)
+  } catch (e) {
+    core.warning(`Error loading plugin at path: ${pluginEntryPath}`)
+  }
 }
 
 export async function loadPluginViaJsFile(pluginFolderPath: string): Promise<Plugin | undefined> {

.github/actions/find/tests/findForUrl.test.ts

@@ -3,8 +3,8 @@ import * as core from '@actions/core'
 import {findForUrl} from '../src/findForUrl.js'
 import {AxeBuilder} from '@axe-core/playwright'
 import axe from 'axe-core'
-import * as pluginManager from '../src/pluginManager'
-import { Plugin } from '../src/pluginManager/types.js'
+import * as pluginManager from '../src/pluginManager/index.js'
+import type { Plugin } from '../src/pluginManager/types.js'
 import {clearCache} from '../src/scansContextProvider.js'
 
 vi.mock('@actions/core', {spy: true})

.github/actions/find/tests/pluginManager.test.ts

@@ -3,15 +3,15 @@ import {describe, it, expect, vi, beforeEach} from 'vitest'
 import * as fs from 'fs'
 import * as esbuild from 'esbuild'
 import * as dynamicImportModule from '../src/dynamicImport.js'
-import * as pluginManager from '../src/pluginManager'
+import * as pluginManager from '../src/pluginManager/index.js'
 import * as core from '@actions/core'
 import * as pluginLoaders from '../src/pluginManager/pluginFileLoaders.js'
 
 // - enable spying on fs
 // https://vitest.dev/guide/browser/#limitations
 vi.mock('fs', {spy: true})
 vi.mock('esbuild', {spy: true})
-vi.mock('../src/pluginManager', {spy: true})
+vi.mock('../src/pluginManager/index.js', {spy: true})
 vi.mock('@actions/core', {spy: true})
 
 describe('pluginManager', () => {

.github/scanner-plugins/temp-test-scan/index.js

@@ -1,5 +1,9 @@
-export default async function reflowScan({ page, addFinding } = {}) {
-  console.log('testing js file import')
+
+// - this exist as a test to verify that loading plugins
+//   via js files still works and there are no regressions
+
+export default async function JSFilePluginLoadTest({ page, addFinding } = {}) {
+  console.log('testing loading plugin using js file')
 }
 
-export const name = 'temp-test-scan'
+export const name = 'js-file-plugin-load-test'