copilot PR feedback

- update plugin manager tests to account for new isDirectory check

Author: abdulahmad307

.github/actions/find/src/findForUrl.ts

@@ -22,7 +22,7 @@ export async function findForUrl(
   await page.goto(url)
   console.log(`Scanning ${page.url()}`)
 
-  let findings: Finding[] = []
+  const findings: Finding[] = []
   const addFinding = (findingData: Finding) => {
     findings.push(findingData)
   }
@@ -58,18 +58,18 @@ export async function findForUrl(
       screenshotId = await generateScreenshots(page)
     }
 
-    findings =
-      rawFindings?.violations.map(violation => ({
-        scannerType: 'axe',
-        url,
-        html: violation.nodes[0].html.replace(/'/g, '''),
-        problemShort: violation.help.toLowerCase().replace(/'/g, '''),
-        problemUrl: violation.helpUrl.replace(/'/g, '''),
-        ruleId: violation.id,
-        solutionShort: violation.description.toLowerCase().replace(/'/g, '''),
-        solutionLong: violation.nodes[0].failureSummary?.replace(/'/g, '''),
-        screenshotId,
-      })) || []
+    const axeFindings = rawFindings?.violations.map(violation => ({
+      scannerType: 'axe',
+      url,
+      html: violation.nodes[0].html.replace(/'/g, '''),
+      problemShort: violation.help.toLowerCase().replace(/'/g, '''),
+      problemUrl: violation.helpUrl.replace(/'/g, '''),
+      ruleId: violation.id,
+      solutionShort: violation.description.toLowerCase().replace(/'/g, '''),
+      solutionLong: violation.nodes[0].failureSummary?.replace(/'/g, '''),
+      screenshotId,
+    }))
+    findings.push(...(axeFindings || []))
   } catch (e) {
     console.error('Error during accessibility scan:', e)
   }

.github/actions/find/src/pluginManager.ts

@@ -72,8 +72,11 @@ export async function loadPluginsFromPath({readPath, importPath}: {readPath: str
   try {
     const res = fs.readdirSync(readPath)
     for (const pluginFolder of res) {
-      console.log('Found plugin: ', pluginFolder)
-      plugins.push(await dynamicImport(path.join(importPath, pluginFolder, '/index.js')))
+      const pluginFolderPath = path.join(importPath, pluginFolder)
+      if (fs.lstatSync(pluginFolderPath).isDirectory()) {
+        console.log('Found plugin: ', pluginFolder)
+        plugins.push(await dynamicImport(path.join(importPath, pluginFolder, '/index.js')))
+      }
     }
   } catch (e) {
     // - log errors here for granular info

.github/actions/find/src/scansContextProvider.ts

@@ -10,8 +10,8 @@ let scansContext: ScansContext | undefined
 export function getScansContext() {
   if (!scansContext) {
     const scansJson = core.getInput('scans', {required: false})
-    const scansToPerform = JSON.parse(scansJson || '{}')
-    // - if we dont have a scans input
+    const scansToPerform = JSON.parse(scansJson || '[]')
+    // - if we don't have a scans input
     //   or we do have a scans input, but it only has 1 item and its 'axe'
     //   then we only want to run 'axe' and not the plugins
     // - keep in mind, 'onlyAxeScan' is not the same as 'shouldPerformAxeScan'

.github/actions/find/tests/pluginManager.test.ts

@@ -17,6 +17,11 @@ describe('loadPlugins', () => {
     vi.spyOn(fs, 'readdirSync').mockImplementation(readPath => {
       return [readPath + '/plugin-1', readPath + '/plugin-2']
     })
+    vi.spyOn(fs, 'lstatSync').mockImplementation(() => {
+      return {
+        isDirectory: () => true,
+      } as unknown as fs.Stats
+    })
   })
 
   describe('when plugins are not loaded', () => {