remove 'includeScreenshots' argument override in the 'addFinding' function

- update 'Finding' type to include missing fields

Author: abdulahmad307

.github/actions/find/src/pluginManager.ts

@@ -2,7 +2,7 @@ import * as fs from 'fs'
 import * as path from 'path'
 import {fileURLToPath} from 'url'
 import {dynamicImport} from './dynamicImport.js'
-import type {FindingWithContext} from './types.d.js'
+import type {Finding} from './types.d.js'
 import playwright from 'playwright'
 import * as core from '@actions/core'
 
@@ -12,7 +12,7 @@ const __dirname = path.dirname(__filename)
 
 type PluginDefaultParams = {
   page: playwright.Page
-  addFinding: (findingData: FindingWithContext) => void
+  addFinding: (findingData: Finding) => void
   // - this will be coming soon
   // runAxeScan: (options: {includeScreenshots: boolean; page: playwright.Page; findings: Finding[]}) => Promise<void>
 }

.github/actions/find/src/types.d.ts

@@ -1,18 +1,15 @@
 export type Finding = {
+  scannerType: string
   url: string
   html: string
   problemShort: string
   problemUrl: string
   solutionShort: string
   solutionLong?: string
   screenshotId?: string
+  ruleId: string
 }
 
-// export type FindingWithContext = Finding & {
-//   scannerType: string
-//   ruleId?: string
-// }
-
 export type Cookie = {
   name: string
   value: string