Minor updates for consistency

Author: lindseywild

.github/actions/file/tests/generateIssueBody.test.ts

@@ -13,10 +13,10 @@ const baseFinding = {
 
 const findingWithEmptyOptionalFields = {
   scannerType: 'reflow',
-  url: 'https://example.com/page',
-  problemShort: 'elements must meet minimum color contrast ratio thresholds',
-  problemUrl: 'https://dequeuniversity.com/rules/axe/4.10/color-contrast?application=playwright',
-  solutionShort: 'ensure the contrast between foreground and background colors meets WCAG thresholds',
+  url: 'https://example.com/404',
+  problemShort: 'page requires horizontal scrolling at 320x256 viewport',
+  problemUrl: 'https://www.w3.org/WAI/WCAG21/Understanding/reflow.html',
+  solutionShort: 'ensure content is responsive and does not require horizontal scrolling at small viewport sizes',
 }
 
 describe('generateIssueBody', () => {

.github/scanner-plugins/reflow-scan/index.js

@@ -1,5 +1,4 @@
-export default async function reflowScan({ page, addFinding, url } = {}) {
-  console.log('reflow plugin');
+export default async function reflowScan({page, addFinding, url} = {}) {
   const originalViewport = page.viewportSize()
   // Check for horizontal scrolling at 320x256 viewport
   try {
@@ -15,7 +14,7 @@ export default async function reflowScan({ page, addFinding, url } = {}) {
         problemShort: 'page requires horizontal scrolling at 320x256 viewport',
         problemUrl: 'https://www.w3.org/WAI/WCAG21/Understanding/reflow.html',
         solutionShort: 'ensure content is responsive and does not require horizontal scrolling at small viewport sizes',
-        solutionLong: `The page has a scroll width of ${scrollWidth}px but a client width of only ${clientWidth}px at 320x256 viewport, requiring horizontal scrolling. This violates WCAG 2.1 Level AA Success Criterion 1.4.10 (Reflow).`,
+        solutionLong: `The page has a scroll width of ${scrollWidth}px but a client width of only ${clientWidth}px at a 320x256 viewport, requiring horizontal scrolling. This violates WCAG 2.1 Level AA Success Criterion 1.4.10 (Reflow).`,
       })
     }
   } catch (e) {
@@ -28,4 +27,4 @@ export default async function reflowScan({ page, addFinding, url } = {}) {
   }
 }
 
-export const name = 'reflow-scan';
+export const name = 'reflow-scan'

tests/types.d.ts

@@ -1,6 +1,6 @@
 export type Finding = {
   scannerType: string
-  ruleId: string
+  ruleId?: string
   url: string
   html?: string
   problemShort: string