minor adjustments based on copilot feedback (#171)

[Copilot found a few
issues](#170) that I
thought were important to address. This PR adds those fixes to merge to
main before we merge to v2 and release

Author: abdulahmad307

.github/actions/find/src/dynamicImport.ts

@@ -1,3 +1,5 @@
+import {pathToFileURL} from 'url'
+
 // - this exists because it looks like there's no straight-forward
 //   way to mock the dynamic import function, so mocking this instead
 //   (also, if it _is_ possible to mock the dynamic import,
@@ -17,5 +19,5 @@
 //
 // - so this looks like a reasonable approach
 export function dynamicImport(path: string) {
-  return import(path)
+  return import(pathToFileURL(path).href)
 }

.github/actions/find/src/pluginManager.ts

@@ -61,8 +61,20 @@ export async function loadBuiltInPlugins() {
 // exported for mocking/testing. not for actual use
 export async function loadCustomPlugins() {
   core.info('Loading custom plugins')
+  const pluginsPath = path.join(process.cwd(), '.github/scanner-plugins/')
+
+  // - currently, the plugin manager will abort loading
+  //   all plugins if there's an error
+  // - the problem with this is that if a scanner user doesnt
+  //   have custom plugins, they won't have a 'scanner-plugins' folder
+  //   which will cause an error and abort loading all plugins, including built-in ones
+  // - so for custom plugins, if the path doesn't exist, we can return early
+  //   and not abort the loading of built-in plugins
+  if (!fs.existsSync(pluginsPath)) {
+    core.info('No custom plugins found.')
+    return
+  }
 
-  const pluginsPath = path.join(process.cwd(), '/.github/scanner-plugins/')
   await loadPluginsFromPath({pluginsPath})
 }
 
@@ -75,7 +87,7 @@ export async function loadPluginsFromPath({pluginsPath}: {pluginsPath: string})
 
       if (fs.existsSync(pluginFolderPath) && fs.lstatSync(pluginFolderPath).isDirectory()) {
         core.info(`Found plugin: ${pluginFolder}`)
-        plugins.push(await dynamicImport(path.join(pluginsPath, pluginFolder, '/index.js')))
+        plugins.push(await dynamicImport(path.join(pluginsPath, pluginFolder, 'index.js')))
       }
     }
   } catch (e) {