Skip to content

Commit 2c88b1b

Browse files
committed
fix: remove unnecessary @ts-expect-error directives
The octokit type mismatch only manifests with certain dependency resolutions. CI resolves compatible types, so the directives are flagged as unused.
1 parent b629081 commit 2c88b1b

2 files changed

Lines changed: 0 additions & 3 deletions

File tree

lambdas/functions/control-plane/src/github/auth.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ async function createAuth(installationId: number | undefined, ghesApiUrl: string
135135

136136
logger.debug(`GHES API URL: ${ghesApiUrl}`);
137137
if (ghesApiUrl) {
138-
// @ts-expect-error - Type mismatch between @octokit/request and @octokit/types versions
139138
authOptions.request = request.defaults({
140139
baseUrl: ghesApiUrl,
141140
});

lambdas/functions/termination-watcher/src/deregister.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ async function createAuthenticatedClient(ghesApiUrl: string): Promise<Octokit> {
6666
if (ghesApiUrl) {
6767
authOptions.request = request.defaults({ baseUrl: ghesApiUrl });
6868
}
69-
// @ts-expect-error - Type mismatch between @octokit/request and @octokit/auth-app versions
7069
const auth = createAppAuth(authOptions);
7170
const appAuth = await auth({ type: 'app' });
7271
return createOctokitInstance(appAuth.token, ghesApiUrl);
@@ -113,7 +112,6 @@ async function createInstallationClient(
113112
if (ghesApiUrl) {
114113
authOptions.request = request.defaults({ baseUrl: ghesApiUrl });
115114
}
116-
// @ts-expect-error - Type mismatch between @octokit/request and @octokit/auth-app versions
117115
const auth = createAppAuth(authOptions);
118116
const installationAuth = await auth({ type: 'installation' });
119117
return createOctokitInstance(installationAuth.token, ghesApiUrl);

0 commit comments

Comments
 (0)