From ee71e36da1a9bf0d95e3a9c88b66c1d135622657 Mon Sep 17 00:00:00 2001 From: Alicepoltora Date: Sun, 27 Sep 2026 04:22:17 +0700 Subject: [PATCH] fix(usage-metrics): replace deprecated datetime.utcnow() with timezone-aware datetime.now(timezone.utc) datetime.utcnow() was removed in Python 3.12 and returned a naive datetime (no timezone). _format_created_at() should emit ISO 8601 strings that carry timezone info (+00:00) so the upstream metrics API can parse the offset consistently with the rest of Studio. The change replaces: datetime.utcnow().isoformat() with: datetime.now(timezone.utc).isoformat() Regression tests verify the returned string contains a timezone offset. --- backend/services/usage_metrics_service.py | 4 ++-- tests/unit/test_usage_metrics_service.py | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/backend/services/usage_metrics_service.py b/backend/services/usage_metrics_service.py index 8b1e09ba6..af9dafaa7 100644 --- a/backend/services/usage_metrics_service.py +++ b/backend/services/usage_metrics_service.py @@ -4,7 +4,7 @@ import math import os from typing import Any, Optional -from datetime import datetime +from datetime import datetime, timezone import aiohttp from loguru import logger @@ -464,7 +464,7 @@ def _safe_int(self, value: Any) -> int: def _format_created_at(self, created_at) -> str: """Format created_at to ISO8601 string.""" if created_at is None: - return datetime.utcnow().isoformat() + return datetime.now(timezone.utc).isoformat() if isinstance(created_at, datetime): return created_at.isoformat() diff --git a/tests/unit/test_usage_metrics_service.py b/tests/unit/test_usage_metrics_service.py index f670b12d5..00e7b9305 100644 --- a/tests/unit/test_usage_metrics_service.py +++ b/tests/unit/test_usage_metrics_service.py @@ -378,3 +378,18 @@ def test_extract_llm_calls_falls_back_to_primary_without_token_metrics(): "costUsd": 0, } ] + + +def test_format_created_at_returns_utc_isoformat(): + service = UsageMetricsService() + result = service._format_created_at(None) + assert "+" in result # timezone-aware ISO string includes offset like "+00:00" + assert "Z" not in result # should use +00:00, not Z suffix + + +def test_format_created_at_returns_original_datetime_isoformat(): + from datetime import datetime, timezone + service = UsageMetricsService() + dt = datetime(2024, 1, 1, 12, 0, 0, tzinfo=timezone.utc) + result = service._format_created_at(dt) + assert result == "2024-01-01T12:00:00+00:00"