Skip to content

Make styled components a peer dependency #11

Description

@johnmurphy01

We have run into an issue in other packages in which a styled component warning is thrown if the host application also has a dependency on styled components.

Because ims-react-components uses styled components v4, if the host application uses any other version of styled components, then the warning will appear.

It looks like there are several instances of 'styled-components' initialized in this application. This may cause dynamic styles not rendering properly, errors happening during rehydration process and makes your application bigger without a good reason.

See https://s-c.sh/2BAXzed for more info.

We should make styled components a peer dependency of ims-react-components but make sure to test/update any other packages that use this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions