Skip to content
This repository was archived by the owner on Jul 24, 2025. It is now read-only.
This repository was archived by the owner on Jul 24, 2025. It is now read-only.

No indication returned to user when message was not posted #69

Description

@devkev

When oulu is unable to successfully post a message to the Flowdock API, it records the error in its logs. However, it does not inform the user that the message was not delivered. This means that when the API is having trouble receiving messages (like last Friday), IRC users have no way of knowing which (if any) of their messages have actually been sent.

This very severely impacts the usability of the IRC gateway, since there is no way to trust that it has actually delivered any messages - and no way to check, apart from using the web interface or a native client (and avoiding these is usually the point of using the IRC gateway in the first place).

The problem is on line 290 and line 297 of irc_connection.rb. This is where $logger.error is called, but what is almost certainly needed is something like

send_reply(render_unavailable_resource)

or

send_reply(render_cannot_send_to_channel)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions