Skip to content
This repository was archived by the owner on Jul 24, 2025. It is now read-only.
This repository was archived by the owner on Jul 24, 2025. It is now read-only.

Node-Flowdock doesn't work in Node 7 #30

Description

@pimterry

In Node 7, process.EventEmitter doesn't exist (and in Node 6 it's deprecated, and will print a warning), but Session here extends it. See nodejs/node#6862 for more details.

It'd be nice if the engines field in node-flowdock's package.json caught this, but it'd be even better if this worked. You could plausibly move to const EventEmitter = process.EventEmitter || require('events').EventEmitter if you want to keep backwards compatibility too.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions