Skip to content

Commit 8703d38

Browse files
committed
fix(broker): check deferred Close return values in test (errcheck)
First broker PR, so the linter surfaces the original test helpers too. Wrap the deferred syscall.Close / conn.Close calls so errcheck passes.
1 parent 26c275a commit 8703d38

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎internal/cli/broker_dial_unix_test.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ func TestBrokerHTTPClient_DialAndRewrite(t *testing.T) {
9696
}
9797
childFD, parentFD := pair[0], pair[1]
9898
stop := fakeBroker(t, parentFD, upstream.URL, "REAL-KEY") // owns + closes parentFD
99-
defer syscall.Close(childFD)
99+
defer func() { _ = syscall.Close(childFD) }()
100100
defer stop()
101101

102102
client := newBrokerHTTPClient(childFD)
@@ -159,8 +159,8 @@ func TestDefaultNewClient_BrokerMode(t *testing.T) {
159159
if err != nil {
160160
t.Fatalf("socketpair: %v", err)
161161
}
162-
defer syscall.Close(pair[0])
163-
defer syscall.Close(pair[1])
162+
defer func() { _ = syscall.Close(pair[0]) }()
163+
defer func() { _ = syscall.Close(pair[1]) }()
164164

165165
t.Setenv("FLASHDUTY_CRED_FD", strconv.Itoa(pair[0]))
166166
client, err := defaultNewClient()
@@ -210,7 +210,7 @@ func TestBrokerHTTPClient_RefusedReturnsError(t *testing.T) {
210210
t.Fatalf("socketpair: %v", err)
211211
}
212212
childFD, parentFD := pair[0], pair[1]
213-
defer syscall.Close(childFD)
213+
defer func() { _ = syscall.Close(childFD) }()
214214

215215
done := make(chan struct{})
216216
go func() {
@@ -238,7 +238,7 @@ func TestBrokerHTTPClient_RefusedReturnsError(t *testing.T) {
238238
// serveProxyConn is a tiny test upstream-proxy used by fakeBroker; the real
239239
// implementation lives in the runner, this mirrors it for the CLI test.
240240
func serveProxyConn(conn net.Conn, upstream, realKey string) {
241-
defer conn.Close()
241+
defer func() { _ = conn.Close() }()
242242
br := newReadProxy(conn, upstream, realKey)
243243
br.run()
244244
}

0 commit comments

Comments
 (0)