From e05173f0ac0a1932593f386169d07bccdb2277b2 Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Mon, 28 Sep 2026 05:21:02 +0000 Subject: [PATCH 1/3] fix(OSQUERY-007): 3 review findings across 3 files --- osquery/tables/system/darwin/homebrew_packages.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/osquery/tables/system/darwin/homebrew_packages.cpp b/osquery/tables/system/darwin/homebrew_packages.cpp index e57dfc4b305..2f270e1e3c3 100644 --- a/osquery/tables/system/darwin/homebrew_packages.cpp +++ b/osquery/tables/system/darwin/homebrew_packages.cpp @@ -38,6 +38,8 @@ const std::set kHomebrewPrefixes = { "/opt/homebrew", }; +namespace { + std::vector getHomebrewAppInfoPlistPaths(const std::string& root) { std::vector results; auto status = osquery::listDirectoriesInDirectory(root, results); @@ -338,6 +340,8 @@ void packagesFromPrefix(QueryData& results, computeVersionsForCasks(results, prefix, userRequested); } +} // namespace + QueryData genHomebrewPackages(QueryContext& context) { QueryData results; From 8f0a92e3ba5c24f96ac130680d7283c1c397dc0b Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Mon, 28 Sep 2026 05:21:03 +0000 Subject: [PATCH 2/3] fix(OSQUERY-007): 3 review findings across 3 files --- osquery/tables/system/windows/shimcache.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/osquery/tables/system/windows/shimcache.cpp b/osquery/tables/system/windows/shimcache.cpp index 8e6feeb14d6..b83c37741d4 100644 --- a/osquery/tables/system/windows/shimcache.cpp +++ b/osquery/tables/system/windows/shimcache.cpp @@ -22,6 +22,11 @@ #include #include +namespace osquery { +namespace tables { + +namespace { + const int kWin8 = 256; const int kWin10PreCreator = 96; const int kWin10Creator = 104; @@ -44,8 +49,7 @@ struct ShimcacheData { boost::optional execution_flag; }; -namespace osquery { -namespace tables { +} // namespace auto parseShimcacheData(const std::string& token, const boost::optional& execution_flag_exists) { @@ -227,3 +231,4 @@ QueryData genShimcache(QueryContext& context) { } // namespace tables } // namespace osquery + From 313bd9910f43d7211301ceb953921c6721f5ca12 Mon Sep 17 00:00:00 2001 From: "flamingo[bot]" <277372822+flamingo[bot]@users.noreply.github.com> Date: Mon, 28 Sep 2026 05:21:05 +0000 Subject: [PATCH 3/3] fix(OSQUERY-007): 3 review findings across 3 files --- osquery/events/darwin/es_utils.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/osquery/events/darwin/es_utils.cpp b/osquery/events/darwin/es_utils.cpp index 2d3afc38e32..231cf40b2a0 100644 --- a/osquery/events/darwin/es_utils.cpp +++ b/osquery/events/darwin/es_utils.cpp @@ -162,12 +162,4 @@ void getProcessProperties(const es_process_t* p, ec->cwd = getCwdPathFromPid(ec->pid); } -void appendQuotedString(std::ostream& out, std::string s, char delim) { - if (s.find(delim) != std::string::npos || s.find('"') != std::string::npos) { - out << std::quoted(s) << delim; - } else { - out << s << delim; - } -} - } // namespace osquery