From 7be76f3c09a7967dacc306f939b1aebcfa291a90 Mon Sep 17 00:00:00 2001 From: Raghu Betina Date: Thu, 24 Sep 2026 10:40:06 -0500 Subject: [PATCH] Use Selenium's default session request timeout The 30-second cutoff rejected a Codespaces browser that started after 31.7 seconds. Let Selenium's own deadline accommodate slow starts instead of adding warm-up or retry machinery. Provider qualification remains tracked in firstdraft/firstdraft#729. --- .devcontainer/compose.yaml | 1 - CONTRIBUTING.md | 5 +++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.devcontainer/compose.yaml b/.devcontainer/compose.yaml index 7d525d3..0f6eb2c 100644 --- a/.devcontainer/compose.yaml +++ b/.devcontainer/compose.yaml @@ -13,7 +13,6 @@ services: environment: SE_NODE_MAX_SESSIONS: "2" SE_NODE_OVERRIDE_MAX_SESSIONS: "true" - SE_SESSION_REQUEST_TIMEOUT: "30" shm_size: 2gb postgres: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cd75213..0a1a737 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -178,6 +178,11 @@ their generated `.devcontainer/compose.yaml` and the running container's Compose [browser-testing instructions](README.md#7-open-your-app). The generated health check uses Selenium's supplied `/opt/bin/check-grid.sh`; Compose owns readiness for that command and fresh generated Dev Container startup. +Selenium uses its upstream session-request queue deadline, currently 300 seconds. The generated app's Ruby client +retains its separate 60-second HTTP read timeout, so an unanswered session request can still fail sooner. +The former 30-second override rejected a slow first browser start in Codespaces; the observation and remaining +qualification are tracked in [Service #729](https://github.com/firstdraft/firstdraft/issues/729). + The Docker-outside-of-Docker Feature reaches the host daemon: that host is a disposable VM in Codespaces, but it is the developer's own machine on the supported local path. Do not run an untrusted workspace or agent with that socket mounted. The planning workspace starts Selenium only when browser proof requests it.