Skip to content

fix(bigquery-firestore-export): DISPLAY_NAME edits silently no-op on update #3141

Description

@cabljac

DISPLAY_NAME is immutable: true in the extension but mutable in the kit, and constructUpdateTransferConfigRequest never adds display_name to the DTS update mask. Editing it and redeploying reports success and changes nothing.

Fix in #2980: display_name joins the mask when it differs, alongside the existing schedule and notification_pubsub_topic comparisons. Verified against a live transfer config. The alternative, making the param immutable to match the extension, was rejected in favour of keeping the kit's mutable param, consistent with the forward ruling in #3030.

Parity ledger: #2974, bigquery-firestore-export DISPLAY_NAME params row.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions