Skip to content

Potential deserialization error for mismatched classes #84

Description

@russgold

If the sender's version of a class has a writeObject method, it is considered to use custom serialization, which adds two bytes at the start of the serialized data; however, the receiving side has no way to know if the sender has a writeObject method, as that does not change the repository ID. The code checks the local class to see if it has one, but that is not guaranteed to be the same as the sender's version. That could well cause deserialization to fail, if the two versions of the class differ in that regard.

To fix this, it is clear that the computation of the repository ID must take that into consideration; as far as I can tell, it does not. It is easy to write unit tests that create the failure. If the repositoryID is updated to take this into consideration, such a change will cause the use of FVD deserialization, which will indicate whether custom serialization is being used.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions