Possible regression when deleting on a @OneToOne relationship with entities that have the @SoftDelete property

[pullari]

Hello.

We noticed in our project, after updating to ebean version 17.11.1, that if we have two entities with the SoftDelete property in a OneToOne relationship, soft deleting the entity on the OneToOne "one" side and then calling refresh on the "many" side entity would not mark the relationship as null or would not mark the deleted entity behind the reference as deleted either.

I've got a minimal reproduction example on my github here: https://github.com/pullari/ebean-soft-delete-new-bean-test
but here's also some pseudo code on the issue to illustrate what I mean

public class Parent extends Model {
  @Id public long id;
  @SoftDelete public boolean deleted;
  @OneToOne(mappedBy = "parent")
  public Child child;
}

public class Child extends Model {
  @Id public long id;
  @SoftDelete public boolean deleted;
  @OneToOne public Parent parent;
}

public void insertFindDelete() {
  Parent parent = new Parent();
  parent.save();

  Child child = new Child();
  child.parent = parent;
  child.save();

  parent.refresh();

  Assert.assertFalse("Should not be deleted yet", parent.child.deleted);

  child.delete();
  parent.refresh();

  Assert.assertNull(parent.child);
  // On ebean 17.11.0 and earlier this passes
  // On ebean 17.11.1 and later this fails with parent.child being <Child@0(id:1, deleted:false)>
}

This was not the behaviour on 17.11.0 or earlier but is the behaviour in at least version 17.11.1 and 19.6.0.
Would this be considered a regression or is this expected?

Thanks in advance.

[rbygrave]

I won't be able to look at this for 2 weeks. Off hand it isn't clear to me if this issue is about refersh() specifically (that is, does a new query work as expected). Maybe it is more clear is the example app.

[pullari]

Thanks for your prompt answer. No hurry on my account.

If it helps, I verified that if I do

Parent newlyFetchedParent = DB.find(Parent.class).where().idEq(parent.id).findOne();
Assert.assertNull(newlyFetchedParent.child);

instead of refreshing like in the example then the test passes with all the three ebean versions I tested with, so it would seem that fetching a new entity reference with a query behaves differently than calling refresh on the entity. Added an assert about this in the example app.