feat: pass forward downstream app flags

Author: denyszhak

cmd/cli/commands/launch.go

@@ -76,12 +76,13 @@ func newLaunchCmd() *cobra.Command {
 		dryRun bool
 	)
 	c := &cobra.Command{
-		Use:       "launch APP",
+		Use:       "launch APP [-- APP_ARGS...]",
 		Short:     "Launch an app configured to use Docker Model Runner",
-		Args:      requireExactArgs(1, "launch", "APP"),
+		Args:      cobra.MinimumNArgs(1),
 		ValidArgs: supportedApps,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			app := strings.ToLower(args[0])
+			appArgs := args[1:]
 
 			runner, err := getStandaloneRunner(cmd.Context())
 			if err != nil {
@@ -97,7 +98,7 @@ func newLaunchCmd() *cobra.Command {
 				return launchContainerApp(cmd, ca, ep.container, image, port, detach, dryRun)
 			}
 			if cli, ok := hostApps[app]; ok {
-				return launchHostApp(cmd, app, ep.host, cli, dryRun)
+				return launchHostApp(cmd, app, ep.host, cli, appArgs, dryRun)
 			}
 			return fmt.Errorf("unsupported app %q (supported: %s)", app, strings.Join(supportedApps, ", "))
 		},
@@ -180,7 +181,7 @@ func launchContainerApp(cmd *cobra.Command, ca containerApp, baseURL string, ima
 }
 
 // launchHostApp launches a native host app executable.
-func launchHostApp(cmd *cobra.Command, bin string, baseURL string, cli hostApp, dryRun bool) error {
+func launchHostApp(cmd *cobra.Command, bin string, baseURL string, cli hostApp, appArgs []string, dryRun bool) error {
 	if _, err := exec.LookPath(bin); err != nil {
 		cmd.Printf("%q executable not found in PATH.\n", bin)
 		if cli.envFn != nil {
@@ -198,13 +199,13 @@ func launchHostApp(cmd *cobra.Command, bin string, baseURL string, cli hostApp,
 
 	env := cli.envFn(baseURL)
 	if dryRun {
-		cmd.Printf("Would run: %s\n", bin)
+		cmd.Printf("Would run: %s %s\n", bin, strings.Join(appArgs, " "))
 		for _, e := range env {
 			cmd.Printf("  %s\n", e)
 		}
 		return nil
 	}
-	return runExternal(cmd, withEnv(env...), bin)
+	return runExternal(cmd, withEnv(env...), bin, appArgs...)
 }
 
 // launchUnconfigurableHostApp handles host apps that need manual config rather than env vars.

cmd/cli/commands/launch_test.go

@@ -230,7 +230,7 @@ func TestLaunchHostAppDryRunOpenai(t *testing.T) {
 
 	cli := hostApp{envFn: openaiEnv(openaiPathSuffix)}
 	// Use "ls" as a bin that exists in PATH
-	err := launchHostApp(cmd, "ls", testBaseURL, cli, true)
+	err := launchHostApp(cmd, "ls", testBaseURL, cli, nil, true)
 	require.NoError(t, err)
 
 	output := buf.String()
@@ -245,7 +245,7 @@ func TestLaunchHostAppDryRunCodex(t *testing.T) {
 	cmd := newTestCmd(buf)
 
 	cli := hostApp{envFn: openaiEnv("/v1")}
-	err := launchHostApp(cmd, "ls", testBaseURL, cli, true)
+	err := launchHostApp(cmd, "ls", testBaseURL, cli, nil, true)
 	require.NoError(t, err)
 
 	output := buf.String()
@@ -255,12 +255,24 @@ func TestLaunchHostAppDryRunCodex(t *testing.T) {
 	require.NotContains(t, output, "/engines/v1")
 }
 
+func TestLaunchHostAppDryRunWithArgs(t *testing.T) {
+	buf := new(bytes.Buffer)
+	cmd := newTestCmd(buf)
+
+	cli := hostApp{envFn: openaiEnv(openaiPathSuffix)}
+	err := launchHostApp(cmd, "ls", testBaseURL, cli, []string{"-m", "ai/qwen3"}, true)
+	require.NoError(t, err)
+
+	output := buf.String()
+	require.Contains(t, output, "Would run: ls -m ai/qwen3")
+}
+
 func TestLaunchHostAppDryRunAnthropic(t *testing.T) {
 	buf := new(bytes.Buffer)
 	cmd := newTestCmd(buf)
 
 	cli := hostApp{envFn: anthropicEnv}
-	err := launchHostApp(cmd, "ls", testBaseURL, cli, true)
+	err := launchHostApp(cmd, "ls", testBaseURL, cli, nil, true)
 	require.NoError(t, err)
 
 	output := buf.String()
@@ -275,7 +287,7 @@ func TestLaunchHostAppNotFound(t *testing.T) {
 	cmd := newTestCmd(buf)
 
 	cli := hostApp{envFn: openaiEnv(openaiPathSuffix)}
-	err := launchHostApp(cmd, "nonexistent-binary-xyz", testBaseURL, cli, false)
+	err := launchHostApp(cmd, "nonexistent-binary-xyz", testBaseURL, cli, nil, false)
 	require.Error(t, err)
 	require.Contains(t, err.Error(), "not found")
 
@@ -289,7 +301,7 @@ func TestLaunchHostAppNotFoundNilEnvFn(t *testing.T) {
 	cmd := newTestCmd(buf)
 
 	cli := hostApp{envFn: nil}
-	err := launchHostApp(cmd, "nonexistent-binary-xyz", testBaseURL, cli, false)
+	err := launchHostApp(cmd, "nonexistent-binary-xyz", testBaseURL, cli, nil, false)
 	require.Error(t, err)
 
 	output := buf.String()
@@ -326,13 +338,13 @@ func TestNewLaunchCmdValidArgs(t *testing.T) {
 	require.Equal(t, supportedApps, cmd.ValidArgs)
 }
 
-func TestNewLaunchCmdRequiresExactlyOneArg(t *testing.T) {
+func TestNewLaunchCmdRequiresAtLeastOneArg(t *testing.T) {
 	cmd := newLaunchCmd()
 	cmd.SetArgs([]string{})
 	err := cmd.Execute()
 
 	require.Error(t, err)
-	require.Contains(t, err.Error(), "requires 1 argument")
+	require.Contains(t, err.Error(), "requires at least 1 arg")
 }
 
 func TestNewLaunchCmdDispatchContainerApp(t *testing.T) {