-
Notifications
You must be signed in to change notification settings - Fork 116
Expand file tree
/
Copy pathutils_test.go
More file actions
244 lines (209 loc) · 7.17 KB
/
utils_test.go
File metadata and controls
244 lines (209 loc) · 7.17 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
package commands
import (
"bytes"
"encoding/json"
"errors"
"fmt"
"io"
"net/http"
"net/url"
"strings"
"testing"
"github.com/docker/model-runner/cmd/cli/desktop"
mockdesktop "github.com/docker/model-runner/cmd/cli/mocks"
"github.com/docker/model-runner/pkg/inference"
"github.com/docker/model-runner/pkg/inference/backends/vllm"
"github.com/docker/model-runner/pkg/inference/scheduling"
"github.com/spf13/cobra"
"github.com/stretchr/testify/require"
"go.uber.org/mock/gomock"
)
func TestStripDefaultsFromModelName(t *testing.T) {
tests := []struct {
name string
input string
expected string
}{
{
name: "ai prefix and latest tag",
input: "ai/gemma3:latest",
expected: "gemma3",
},
{
name: "ai prefix with custom tag",
input: "ai/gemma3:v1",
expected: "gemma3:v1",
},
{
name: "custom org with latest tag",
input: "myorg/gemma3:latest",
expected: "myorg/gemma3",
},
{
name: "simple model name with latest",
input: "gemma3:latest",
expected: "gemma3",
},
{
name: "simple model name without tag",
input: "gemma3",
expected: "gemma3",
},
{
name: "ai prefix without tag",
input: "ai/gemma3",
expected: "gemma3",
},
{
name: "huggingface model with latest",
input: "hf.co/bartowski/model:latest",
expected: "hf.co/bartowski/model",
},
{
name: "huggingface model with custom tag",
input: "hf.co/bartowski/model:Q4_K_S",
expected: "hf.co/bartowski/model:Q4_K_S",
},
{
name: "empty string",
input: "",
expected: "",
},
{
name: "docker.io registry with ai prefix and latest tag",
input: "docker.io/ai/gemma3:latest",
expected: "gemma3",
},
{
name: "index.docker.io registry with ai prefix and latest tag",
input: "index.docker.io/ai/gemma3:latest",
expected: "gemma3",
},
{
name: "docker.io registry with ai prefix and custom tag",
input: "docker.io/ai/gemma3:v1",
expected: "gemma3:v1",
},
{
name: "docker.io registry with custom org and latest tag",
input: "docker.io/myorg/gemma3:latest",
expected: "myorg/gemma3",
},
{
name: "index.docker.io registry with custom org and latest tag",
input: "index.docker.io/myorg/gemma3:latest",
expected: "myorg/gemma3",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := stripDefaultsFromModelName(tt.input)
if result != tt.expected {
t.Errorf("stripDefaultsFromModelName(%q) = %q, want %q", tt.input, result, tt.expected)
}
})
}
}
// TestHandleClientErrorFormat verifies that the error format follows the expected pattern.
func TestHandleClientErrorFormat(t *testing.T) {
t.Run("error format is message: original error", func(t *testing.T) {
originalErr := fmt.Errorf("network timeout")
message := "Failed to fetch data"
result := handleClientError(originalErr, message)
expected := fmt.Errorf("%s: %w", message, originalErr).Error()
if result.Error() != expected {
t.Errorf("Error format mismatch.\nExpected: %q\nGot: %q", expected, result.Error())
}
if !errors.Is(result, originalErr) {
t.Error("Error wrapping is not preserved - errors.Is() check failed")
}
})
}
func setupDesktopClientStatusMock(t *testing.T, ctrl *gomock.Controller, backendStatus map[string]string) {
t.Helper()
client := mockdesktop.NewMockDockerHttpClient(ctrl)
modelRunner = desktop.NewContextForMock(client)
desktopClient = desktop.New(modelRunner)
statusJSON, err := json.Marshal(backendStatus)
require.NoError(t, err)
expectedModelsURL := modelRunner.URL(inference.ModelsPrefix)
expectedStatusURL := modelRunner.URL(inference.InferencePrefix + "/status")
expectedUserAgent := "docker-model-cli/" + desktop.Version
client.EXPECT().Do(gomock.Cond(func(req any) bool {
r, ok := req.(*http.Request)
return ok && r.URL.String() == expectedModelsURL && r.Header.Get("User-Agent") == expectedUserAgent
})).Return(&http.Response{StatusCode: http.StatusOK, Body: io.NopCloser(strings.NewReader("{}"))}, nil)
client.EXPECT().Do(gomock.Cond(func(req any) bool {
r, ok := req.(*http.Request)
return ok && r.URL.String() == expectedStatusURL && r.Header.Get("User-Agent") == expectedUserAgent
})).Return(&http.Response{StatusCode: http.StatusOK, Body: io.NopCloser(bytes.NewReader(statusJSON))}, nil)
}
func TestCheckBackendInstalled(t *testing.T) {
t.Run("running status string is treated as installed", func(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()
setupDesktopClientStatusMock(t, ctrl, map[string]string{"vllm": "running vllm latest-cuda"})
installed, err := CheckBackendInstalled(vllm.Name)
require.NoError(t, err)
require.True(t, installed)
})
t.Run("not running status is treated as missing", func(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()
setupDesktopClientStatusMock(t, ctrl, map[string]string{"vllm": "not running"})
installed, err := CheckBackendInstalled(vllm.Name)
require.NoError(t, err)
require.False(t, installed)
})
t.Run("error status is treated as missing", func(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()
setupDesktopClientStatusMock(t, ctrl, map[string]string{"vllm": "error failed to start"})
installed, err := CheckBackendInstalled(vllm.Name)
require.NoError(t, err)
require.False(t, installed)
})
}
func TestPromptInstallBackend(t *testing.T) {
cmd := &cobra.Command{Use: "test"}
cmd.SetIn(strings.NewReader("yes\n"))
out := new(bytes.Buffer)
cmd.SetOut(out)
confirmed, err := PromptInstallBackend(vllm.Name, cmd)
require.NoError(t, err)
require.True(t, confirmed)
require.Contains(t, out.String(), "Backend \"vllm\" is not installed")
}
func TestEnsureBackendAvailableCancelled(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()
setupDesktopClientStatusMock(t, ctrl, map[string]string{"vllm": "not running"})
cmd := &cobra.Command{Use: "test"}
cmd.SetIn(strings.NewReader("n\n"))
out := new(bytes.Buffer)
cmd.SetOut(out)
err := EnsureBackendAvailable(vllm.Name, cmd)
require.Error(t, err)
require.ErrorIs(t, err, errBackendInstallationCancelled)
require.Contains(t, out.String(), "docker model install-runner --backend vllm")
}
func TestResolveRequiredBackend(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()
client := mockdesktop.NewMockDockerHttpClient(ctrl)
modelRunner = desktop.NewContextForMock(client)
desktopClient = desktop.New(modelRunner)
model := "ai/functiongemma-vllm:270M"
selection := scheduling.ModelBackendSelection{Backend: vllm.Name, Installed: false}
body, err := json.Marshal(selection)
require.NoError(t, err)
expectedResolveURL := modelRunner.URL(inference.ModelsPrefix + "/backend?model=" + url.QueryEscape(model))
expectedUserAgent := "docker-model-cli/" + desktop.Version
client.EXPECT().Do(gomock.Cond(func(req any) bool {
r, ok := req.(*http.Request)
return ok && r.URL.String() == expectedResolveURL && r.Header.Get("User-Agent") == expectedUserAgent
})).Return(&http.Response{StatusCode: http.StatusOK, Body: io.NopCloser(bytes.NewReader(body))}, nil)
backend, err := ResolveRequiredBackend(model)
require.NoError(t, err)
require.Equal(t, vllm.Name, backend)
}