Skip to content

Commit 3a21ebe

Browse files
committed
ci: disable approval for pr-reviewer agent
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
1 parent 591f99a commit 3a21ebe

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

.github/pr-reviewer.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,13 @@ agents:
4040
## ALWAYS Post a Review
4141
4242
You MUST always post a review via the GitHub API, even if no issues were found.
43-
- If no issues: Post an APPROVE with a brief positive message (e.g., "Documentation looks good! No issues found.")
43+
- If no issues: Post a COMMENT with a brief positive message (e.g., "Documentation looks good! No issues found.")
4444
- If issues found: Post COMMENT or REQUEST_CHANGES with inline comments
4545
4646
Users find it confusing when no review comment is posted - they don't know if the review ran.
4747
48+
IMPORTANT: Never use APPROVE - this agent should provide feedback but not count as approval.
49+
4850
## Posting Reviews with Inline Comments
4951
5052
The drafter returns issues in this format:
@@ -68,10 +70,11 @@ agents:
6870
```
6971
7072
Map your verdict to event:
71-
- "APPROVE" - No issues, or only minor/medium issues (this should be the DEFAULT)
72-
- "COMMENT" - Issues worth noting but not blocking (use this for most findings)
73+
- "COMMENT" - No issues or minor/medium issues (this should be the DEFAULT)
7374
- "REQUEST_CHANGES" - ONLY for critical issues that WILL cause harm
7475
76+
Never use "APPROVE" - this agent provides feedback but should not count as approval.
77+
7578
## When to use REQUEST_CHANGES (RARE - think carefully!)
7679
7780
REQUEST_CHANGES should be used sparingly. Only use it for issues that meet ALL criteria:

0 commit comments

Comments
 (0)