Skip to content

Commit 04f9e20

Browse files
authored
Merge pull request #24591 from dvdksn/sbx-follow-up-fixes
sandboxes: follow-up fixes and clarifications from sbx docs rewrite
1 parent 77abf02 commit 04f9e20

5 files changed

Lines changed: 36 additions & 14 deletions

File tree

.agents/skills/check-pr/SKILL.md

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ action.
3636

3737
## 2. If merged
3838

39-
Report the final state. No further action needed.
39+
Report the final state. Then check for any unanswered review comments (both
40+
top-level and inline) and reply to each one explaining what was done or that
41+
the issue was addressed in a follow-up. Skip to step 6 after.
4042

4143
## 3. If closed without merge
4244

@@ -75,7 +77,27 @@ another PR, closed by automation.
7577
--field in_reply_to=<comment-id> \
7678
--field body="<response>"
7779
```
78-
- End every comment with a `Generated by [Claude Code](https://claude.com/claude-code)` footer
80+
- End every comment reply with a `Generated by [Claude Code](https://claude.com/claude-code)` footer
81+
- Resolve each thread via GraphQL after replying:
82+
```bash
83+
# Get thread IDs
84+
gh api graphql -f query='
85+
query($owner:String!, $repo:String!, $pr:Int!) {
86+
repository(owner:$owner, name:$repo) {
87+
pullRequest(number:$pr) {
88+
reviewThreads(first:50) {
89+
nodes { id isResolved comments(first:1) { nodes { path } } }
90+
}
91+
}
92+
}
93+
}' -f owner=docker -f repo=docs -F pr=$ARGUMENTS \
94+
--jq '.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false) | {id, path: .comments.nodes[0].path}'
95+
96+
# Resolve a thread
97+
gh api graphql -f query='
98+
mutation($id:ID!) { resolveReviewThread(input:{threadId:$id}) { thread { isResolved } } }
99+
' -f id=<thread-id>
100+
```
79101
- Re-request review if changes were requested
80102

81103
## 6. Report

content/manuals/ai/sandboxes/agents/custom-environments.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,11 @@ CLI, and common development tools like Node.js, Python, Go, and Java.
8686

8787
Each variant also has a `-docker` version (for example,
8888
`claude-code-docker`) that includes a full Docker Engine running inside the
89-
sandbox. The `-docker` variants are the defaults used by `sbx run` on macOS
90-
and Linux. They run in privileged mode with a dedicated block volume at
91-
`/var/lib/docker`, and `dockerd` starts automatically.
89+
sandbox — no local Docker daemon required. The `-docker` variants are the
90+
defaults used by `sbx run` on macOS and Linux. These variants run in
91+
privileged mode inside the microVM (not on your host), with a dedicated block
92+
volume at `/var/lib/docker`, and `dockerd` starts automatically inside the
93+
sandbox.
9294

9395
The block volume defaults to 50 GB and uses a sparse file, so it only
9496
consumes disk space as Docker writes to it. On Windows, the volume is not

content/manuals/ai/sandboxes/docker-desktop.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ weight: 80
99

1010
Docker Desktop includes a built-in sandbox feature for running AI coding
1111
agents in isolated microVMs using the `docker sandbox` command. This is a
12-
convenience integration with limited features compared to the standalone
13-
sandbox CLI.
12+
convenience integration. For full functionality, use the standalone `sbx`
13+
CLI instead.
1414

1515
> [!NOTE]
1616
> The standalone `sbx` CLI provides more features, more flexibility, and doesn't
@@ -112,10 +112,7 @@ $ docker sandbox run <name> -- --continue
112112
Each sandbox is a lightweight microVM with its own kernel, using your system's
113113
native virtualization (macOS virtualization.framework, Windows Hyper-V). The
114114
default agent templates include a private Docker daemon, so `docker build` and
115-
`docker compose up` run inside the sandbox without affecting your host. On
116-
Windows, the Docker daemon is not included by default. See
117-
[Troubleshooting](troubleshooting.md#docker-not-available-inside-the-sandbox-on-windows)
118-
for a workaround.
115+
`docker compose up` run inside the sandbox without affecting your host.
119116

120117
```plaintext
121118
Host system

content/manuals/ai/sandboxes/get-started.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ system.
1515
## Prerequisites
1616

1717
- macOS (Apple silicon) or Windows (x86_64, Windows 11 required)
18-
- If you're on Windows, enable Windows Hypervisor Platform (requires
19-
elevated permissions):
18+
- If you're on Windows, enable Windows Hypervisor Platform. Open an elevated
19+
PowerShell prompt (Run as Administrator) and run:
2020
```powershell
2121
Enable-WindowsOptionalFeature -Online -FeatureName HypervisorPlatform -All
2222
```

content/manuals/ai/sandboxes/troubleshooting.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ If credentials are configured correctly but API calls still fail, check
5656
the `transparent` proxy don't get credential injection. This can happen when a
5757
client inside the sandbox (such as a process in a Docker container) isn't
5858
configured to use the forward proxy. See
59-
[Monitoring network activity](security/policy.md#monitoring-network-activity)
59+
[Monitoring network activity](security/policy.md#monitoring)
6060
for details.
6161

6262
## Docker not available inside the sandbox on Windows
@@ -83,6 +83,7 @@ an unprivileged user without `CAP_CHOWN`, so the operation is denied.
8383
Use the tar exporter and extract the archive instead:
8484

8585
```console
86+
$ mkdir -p ./result
8687
$ docker build --output type=tar,dest=- . | tar xf - -C ./result
8788
```
8889

0 commit comments

Comments
 (0)