Skip to content

Commit f699806

Browse files
committed
modelerrors: unexport ParseRetryAfterHeader
Only called within the package (by WrapHTTPError and tests). Rename to parseRetryAfterHeader to reduce the public API surface. Assisted-By: docker-agent
1 parent e76494e commit f699806

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

pkg/modelerrors/modelerrors.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func WrapHTTPError(statusCode int, resp *http.Response, err error) error {
5555
}
5656
var retryAfter time.Duration
5757
if resp != nil {
58-
retryAfter = ParseRetryAfterHeader(resp.Header.Get("Retry-After"))
58+
retryAfter = parseRetryAfterHeader(resp.Header.Get("Retry-After"))
5959
}
6060
return &StatusError{
6161
StatusCode: statusCode,
@@ -330,10 +330,10 @@ func isRetryableModelError(err error) bool {
330330
return false
331331
}
332332

333-
// ParseRetryAfterHeader parses a Retry-After header value.
333+
// parseRetryAfterHeader parses a Retry-After header value.
334334
// Supports both seconds (integer) and HTTP-date formats per RFC 7231 §7.1.3.
335335
// Returns 0 if the value is empty, invalid, or results in a non-positive duration.
336-
func ParseRetryAfterHeader(value string) time.Duration {
336+
func parseRetryAfterHeader(value string) time.Duration {
337337
if value == "" {
338338
return 0
339339
}

pkg/modelerrors/modelerrors_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -261,23 +261,23 @@ func TestParseRetryAfterHeader(t *testing.T) {
261261
for _, tt := range tests {
262262
t.Run(tt.name, func(t *testing.T) {
263263
t.Parallel()
264-
got := ParseRetryAfterHeader(tt.value)
265-
assert.Equal(t, tt.expected, got, "ParseRetryAfterHeader(%q)", tt.value)
264+
got := parseRetryAfterHeader(tt.value)
265+
assert.Equal(t, tt.expected, got, "parseRetryAfterHeader(%q)", tt.value)
266266
})
267267
}
268268

269269
t.Run("HTTP-date in the future", func(t *testing.T) {
270270
t.Parallel()
271271
future := time.Now().Add(10 * time.Second).UTC().Format(http.TimeFormat)
272-
got := ParseRetryAfterHeader(future)
272+
got := parseRetryAfterHeader(future)
273273
assert.Greater(t, got, 0*time.Second, "should return positive duration for future HTTP-date")
274274
assert.LessOrEqual(t, got, 11*time.Second, "should not exceed ~10s for near-future date")
275275
})
276276

277277
t.Run("HTTP-date in the past", func(t *testing.T) {
278278
t.Parallel()
279279
past := time.Now().Add(-10 * time.Second).UTC().Format(http.TimeFormat)
280-
got := ParseRetryAfterHeader(past)
280+
got := parseRetryAfterHeader(past)
281281
assert.Equal(t, 0*time.Second, got, "should return 0 for past HTTP-date")
282282
})
283283
}

0 commit comments

Comments
 (0)