memoize desktop_uuid, never expire

Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>

Author: gtardif

pkg/desktop/login.go

@@ -1,6 +1,8 @@
 package desktop
 
-import "context"
+import (
+	"context"
+)
 
 type DockerHubInfo struct {
 	Username string `json:"id"`
@@ -18,9 +20,3 @@ func GetUserInfo(ctx context.Context) DockerHubInfo {
 	_ = ClientBackend.Get(ctx, "/registry/info", &info)
 	return info
 }
-
-func GetUuid(ctx context.Context) string {
-	var uuid string
-	_ = ClientBackend.Get(ctx, "/uuid", &uuid)
-	return uuid
-}

pkg/desktop/uuid.go

@@ -0,0 +1,19 @@
+package desktop
+
+import (
+	"context"
+
+	"github.com/kofalt/go-memoize"
+	"github.com/patrickmn/go-cache"
+)
+
+var uuidMmemoizer = memoize.NewMemoizer(cache.NoExpiration, cache.NoExpiration)
+
+func GetUUID(ctx context.Context) string {
+	uuid, _, _ := uuidMmemoizer.Memoize("desktopUUID", func() (any, error) {
+		var uuid string
+		_ = ClientBackend.Get(ctx, "/uuid", &uuid)
+		return uuid, nil
+	})
+	return uuid.(string)
+}

pkg/telemetry/client.go

@@ -76,7 +76,7 @@ func newClient(ctx context.Context, logger *slog.Logger, enabled, debugMode bool
 	client := &Client{
 		logger:      telemetryLogger,
 		userUUID:    getUserUUID(),
-		desktopUUID: desktop.GetUuid(ctx),
+		desktopUUID: desktop.GetUUID(ctx),
 		enabled:     enabled,
 		debugMode:   debugMode,
 		httpClient:  httpClient,

pkg/telemetry/telemetry_test.go

@@ -566,12 +566,12 @@ func TestGlobalTelemetryFunctions(t *testing.T) {
 	SetGlobalTelemetryVersion("test-version")
 	SetGlobalTelemetryDebugMode(true)
 
-	TrackCommand(context.Background(), "test-command", []string{"arg1"})
+	TrackCommand(t.Context(), "test-command", []string{"arg1"})
 
 	assert.NotNil(t, globalToolTelemetryClient)
 
-	EnsureGlobalTelemetryInitialized(context.Background())
-	client := GetGlobalTelemetryClient(context.Background())
+	EnsureGlobalTelemetryInitialized(t.Context())
+	client := GetGlobalTelemetryClient(t.Context())
 	assert.NotNil(t, client)
 }