Merge pull request #2188 from dgageot/board/upgrade-golangci-lint-add-new-linters-216e8e88

Enable embeddedstructfieldcheck and godoclint linters

Author: dgageot

.golangci.yml

@@ -12,6 +12,7 @@ linters:
     - depguard
     - dogsled
     - durationcheck
+    - embeddedstructfieldcheck
     - errcheck
     - errname
     - errorlint
@@ -20,6 +21,7 @@ linters:
     - forbidigo
     - ginkgolinter
     - gocheckcompilerdirectives
+    - godoclint
     - gochecknoinits
     - gochecksumtype
     - gocritic

cmd/root/eval.go

@@ -21,6 +21,7 @@ const defaultJudgeModel = "anthropic/claude-opus-4-5-20251101"
 
 type evalFlags struct {
 	evaluation.Config
+
 	runConfig config.RuntimeConfig
 	outputDir string
 }

pkg/acp/filesystem.go

@@ -32,6 +32,7 @@ func getSessionID(ctx context.Context) (string, bool) {
 // and edit_file to use the ACP connection for file operations
 type FilesystemToolset struct {
 	*builtin.FilesystemTool
+
 	agent      *Agent
 	workingDir string
 }

pkg/app/app.go

@@ -1038,11 +1038,11 @@ func (a *App) ExportHTML(ctx context.Context, filename string) (string, error) {
 	return export.SessionToFile(a.session, agentInfo.Description, filename)
 }
 
-// UpdateSessionTitle updates the current session's title and persists it.
-// It works with both local and remote runtimes.
 // ErrTitleGenerating is returned when attempting to set a title while generation is in progress.
 var ErrTitleGenerating = errors.New("title generation in progress, please wait")
 
+// UpdateSessionTitle updates the current session's title and persists it.
+// It works with both local and remote runtimes.
 func (a *App) UpdateSessionTitle(ctx context.Context, title string) error {
 	if a.session == nil {
 		return errors.New("no active session")

pkg/content/artifact.go

@@ -19,6 +19,7 @@ import (
 // See https://github.com/opencontainers/image-spec/blob/v1.1.1/manifest.md#guidelines-for-artifact-usage
 type artifactImage struct {
 	v1.Image
+
 	artifactType string
 }
 

pkg/evaluation/eval.go

@@ -32,6 +32,7 @@ import (
 // Runner runs evaluations against an agent.
 type Runner struct {
 	Config
+
 	agentSource config.Source
 	judge       *Judge
 	runConfig   *config.RuntimeConfig

pkg/evaluation/types.go

@@ -10,6 +10,7 @@ import (
 // InputSession wraps a session with its source path for evaluation loading.
 type InputSession struct {
 	*session.Session
+
 	SourcePath string // Path to the source eval file (not serialized)
 }
 

pkg/fake/proxy_test.go

@@ -303,6 +303,7 @@ func TestSimulatedStreamCopy_SSEEvents(t *testing.T) {
 // notifyWriter wraps an http.ResponseWriter and signals on first Write.
 type notifyWriter struct {
 	http.ResponseWriter
+
 	notify   chan struct{}
 	notified bool
 }

pkg/hooks/types.go

@@ -13,32 +13,32 @@ import (
 type EventType string
 
 const (
-	// PreToolUse is triggered before a tool call executes.
+	// EventPreToolUse is triggered before a tool call executes.
 	// Can allow/deny/modify tool calls; can block with feedback.
 	EventPreToolUse EventType = "pre_tool_use"
 
-	// PostToolUse is triggered after a tool completes successfully.
+	// EventPostToolUse is triggered after a tool completes successfully.
 	// Can provide validation, feedback, or additional processing.
 	EventPostToolUse EventType = "post_tool_use"
 
-	// SessionStart is triggered when a session begins or resumes.
+	// EventSessionStart is triggered when a session begins or resumes.
 	// Can load context, setup environment, install dependencies.
 	EventSessionStart EventType = "session_start"
 
-	// SessionEnd is triggered when a session terminates.
+	// EventSessionEnd is triggered when a session terminates.
 	// Can perform cleanup, logging, persist session state.
 	EventSessionEnd EventType = "session_end"
 
-	// OnUserInput is triggered when the agent needs input from the user.
+	// EventOnUserInput is triggered when the agent needs input from the user.
 	// Can log, notify, or perform actions before user interaction.
 	EventOnUserInput EventType = "on_user_input"
 
-	// Stop is triggered when the model finishes its response and is about
+	// EventStop is triggered when the model finishes its response and is about
 	// to hand control back to the user. Can perform post-response validation,
 	// logging, or cleanup.
 	EventStop EventType = "stop"
 
-	// Notification is triggered when the agent emits a notification to the user,
+	// EventNotification is triggered when the agent emits a notification to the user,
 	// such as errors or warnings. Can send external notifications or log events.
 	EventNotification EventType = "notification"
 )

pkg/model/provider/anthropic/adapter.go

@@ -19,6 +19,7 @@ import (
 // streamAdapter adapts the Anthropic stream to our interface
 type streamAdapter struct {
 	retryableStream[anthropic.MessageStreamEventUnion]
+
 	trackUsage         bool
 	toolCall           bool
 	toolID             string