Fix linter issues

- Add blank line after embedded field (embeddedstructfieldcheck)
- Use switch instead of if-else chain (gocritic)
- Combine append chains (gocritic)
- Fix variable shadowing of 'key' import (gocritic)
- Remove nil check that's always true (staticcheck)
- Remove unused width parameter (unparam)
- Fix imports formatting (gci)

Assisted-By: docker-agent

Author: masegraye

pkg/tui/dialog/help.go

@@ -15,6 +15,7 @@ import (
 // helpDialog displays all currently active key bindings in a scrollable dialog.
 type helpDialog struct {
 	readOnlyScrollDialog
+
 	bindings []key.Binding
 }
 
@@ -61,65 +62,72 @@ func (d *helpDialog) renderContent(contentWidth, maxHeight int) []string {
 			continue
 		}
 		keyStr := binding.Keys()[0]
-		if strings.HasPrefix(keyStr, "ctrl+") {
+		switch {
+		case strings.HasPrefix(keyStr, "ctrl+"):
 			ctrlBindings = append(ctrlBindings, binding)
-		} else if keyStr == "esc" || keyStr == "enter" || keyStr == "tab" {
+		case keyStr == "esc" || keyStr == "enter" || keyStr == "tab":
 			globalBindings = append(globalBindings, binding)
-		} else {
+		default:
 			otherBindings = append(otherBindings, binding)
 		}
 	}
 
 	// Render global bindings
 	if len(globalBindings) > 0 {
-		lines = append(lines, styles.DialogHelpStyle.Bold(true).Render("General"))
-		lines = append(lines, "")
+		lines = append(lines,
+			styles.DialogHelpStyle.Bold(true).Render("General"),
+			"",
+		)
 		for _, binding := range globalBindings {
-			lines = append(lines, d.formatBinding(binding, keyStyle, descStyle, contentWidth))
+			lines = append(lines, d.formatBinding(binding, keyStyle, descStyle))
 		}
 		lines = append(lines, "")
 	}
 
 	// Render ctrl bindings
 	if len(ctrlBindings) > 0 {
-		lines = append(lines, styles.DialogHelpStyle.Bold(true).Render("Control Key Shortcuts"))
-		lines = append(lines, "")
+		lines = append(lines,
+			styles.DialogHelpStyle.Bold(true).Render("Control Key Shortcuts"),
+			"",
+		)
 		for _, binding := range ctrlBindings {
-			lines = append(lines, d.formatBinding(binding, keyStyle, descStyle, contentWidth))
+			lines = append(lines, d.formatBinding(binding, keyStyle, descStyle))
 		}
 		lines = append(lines, "")
 	}
 
 	// Render other bindings
 	if len(otherBindings) > 0 {
-		lines = append(lines, styles.DialogHelpStyle.Bold(true).Render("Other"))
-		lines = append(lines, "")
+		lines = append(lines,
+			styles.DialogHelpStyle.Bold(true).Render("Other"),
+			"",
+		)
 		for _, binding := range otherBindings {
-			lines = append(lines, d.formatBinding(binding, keyStyle, descStyle, contentWidth))
+			lines = append(lines, d.formatBinding(binding, keyStyle, descStyle))
 		}
 	}
 
 	return lines
 }
 
 // formatBinding formats a single key binding as "  key  description"
-func (d *helpDialog) formatBinding(binding key.Binding, keyStyle, descStyle lipgloss.Style, width int) string {
+func (d *helpDialog) formatBinding(binding key.Binding, keyStyle, descStyle lipgloss.Style) string {
 	helpInfo := binding.Help()
 	helpKey := helpInfo.Key
 	helpDesc := helpInfo.Desc
-	
+
 	// Calculate spacing to align descriptions
 	const keyWidth = 20
 	const indent = 2
-	
+
 	keyPart := keyStyle.Render(helpKey)
 	descPart := descStyle.Render(helpDesc)
-	
+
 	// Pad the key part to align descriptions
 	keyPartWidth := lipgloss.Width(keyPart)
 	padding := strings.Repeat(" ", max(1, keyWidth-keyPartWidth))
-	
-	return fmt.Sprintf("%s%s%s%s", 
+
+	return fmt.Sprintf("%s%s%s%s",
 		strings.Repeat(" ", indent),
 		keyPart,
 		padding,
@@ -133,10 +141,8 @@ func (d *helpDialog) Init() tea.Cmd {
 
 func (d *helpDialog) Update(msg tea.Msg) (layout.Model, tea.Cmd) {
 	model, cmd := d.readOnlyScrollDialog.Update(msg)
-	if model != nil {
-		if rod, ok := model.(*readOnlyScrollDialog); ok {
-			d.readOnlyScrollDialog = *rod
-		}
+	if rod, ok := model.(*readOnlyScrollDialog); ok {
+		d.readOnlyScrollDialog = *rod
 	}
 	return d, cmd
 }

pkg/tui/tui.go

@@ -1655,7 +1655,7 @@ func (m *appModel) AllBindings() []key.Binding {
 // This filters AllBindings() to show only the most essential commands.
 func (m *appModel) Bindings() []key.Binding {
 	all := m.AllBindings()
-	
+
 	// Define which keys should appear in the status bar
 	statusBarKeys := map[string]bool{
 		"ctrl+c":      true, // quit
@@ -1671,24 +1671,24 @@ func (m *appModel) Bindings() []key.Binding {
 		"ctrl+g":      true, // edit in external editor (editor context)
 		"ctrl+r":      true, // history search (editor context)
 		// Content panel bindings (↑↓, c, e, d) are always included
-		"up":          true,
-		"down":        true,
-		"c":           true,
-		"e":           true,
-		"d":           true,
+		"up":   true,
+		"down": true,
+		"c":    true,
+		"e":    true,
+		"d":    true,
 	}
-	
+
 	// Filter to only include status bar keys
 	var filtered []key.Binding
 	for _, binding := range all {
 		if len(binding.Keys()) > 0 {
-			key := binding.Keys()[0]
-			if statusBarKeys[key] {
+			bindingKey := binding.Keys()[0]
+			if statusBarKeys[bindingKey] {
 				filtered = append(filtered, binding)
 			}
 		}
 	}
-	
+
 	return filtered
 }