fix: resolve golangci-lint issues in models command

- Remove unused env parameter (unparam)
- Use strings.EqualFold for case-insensitive comparison (gocritic)
- Use strings.SplitSeq for range iteration (modernize)
- Fix import ordering: standard > third-party > project (gci)
- Remove trailing blank line

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: masegraye

cmd/root/models.go

@@ -13,7 +13,6 @@ import (
 	"github.com/docker/docker-agent/pkg/cli"
 	"github.com/docker/docker-agent/pkg/config"
 	"github.com/docker/docker-agent/pkg/config/latest"
-	"github.com/docker/docker-agent/pkg/environment"
 	"github.com/docker/docker-agent/pkg/model/provider"
 	"github.com/docker/docker-agent/pkg/modelsdev"
 	"github.com/docker/docker-agent/pkg/telemetry"
@@ -100,13 +99,12 @@ func (f *modelsListFlags) runModelsListCommand(cmd *cobra.Command, args []string
 	// Determine which model auto-selection would pick.
 	autoModel := config.AutoModelConfig(ctx, f.runConfig.ModelsGateway, env, f.runConfig.DefaultModel)
 
-	rows := f.collectModels(ctx, env, availableProviders, autoModel)
+	rows := f.collectModels(ctx, availableProviders, autoModel)
 
 	// Apply provider filter
 	if f.providerFilter != "" {
-		filter := strings.ToLower(f.providerFilter)
 		rows = slices.DeleteFunc(rows, func(r modelRow) bool {
-			return strings.ToLower(r.Provider) != filter
+			return !strings.EqualFold(r.Provider, f.providerFilter)
 		})
 	}
 
@@ -143,7 +141,7 @@ func (f *modelsListFlags) runModelsListCommand(cmd *cobra.Command, args []string
 // collectModels returns all models from the catalog, filtered by credential
 // availability unless --all is set. Default models for each available provider
 // are always included even if the catalog fetch fails.
-func (f *modelsListFlags) collectModels(ctx context.Context, env environment.Provider, availableProviders map[string]bool, autoModel latest.ModelConfig) []modelRow {
+func (f *modelsListFlags) collectModels(ctx context.Context, availableProviders map[string]bool, autoModel latest.ModelConfig) []modelRow {
 	seen := make(map[string]bool)
 	var rows []modelRow
 

cmd/root/models_test.go

@@ -60,7 +60,7 @@ func TestModelsListCommand_ProviderFilter(t *testing.T) {
 
 	output := buf.String()
 	// Every non-header line should be anthropic
-	for _, line := range strings.Split(output, "\n") {
+	for line := range strings.SplitSeq(output, "\n") {
 		line = strings.TrimSpace(line)
 		if line == "" || strings.HasPrefix(line, "PROVIDER") {
 			continue
@@ -166,4 +166,3 @@ func TestModelsListCommand_NoCredentials(t *testing.T) {
 	// DMR is always available as fallback
 	assert.Contains(t, output, "dmr")
 }
-