Skip to content

Commit 4b3a638

Browse files
authored
Merge pull request #2206 from dgageot/avoid-model-lookup
Remove model alias resolution for inline agent model references
2 parents 84d3fc2 + 97fe20c commit 4b3a638

2 files changed

Lines changed: 4 additions & 26 deletions

File tree

pkg/config/model_alias.go

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -44,28 +44,6 @@ func ResolveModelAliases(ctx context.Context, cfg *latest.Config, store *modelsd
4444
}
4545
cfg.Models[name] = modelCfg
4646
}
47-
48-
// Resolve inline model references in agents (e.g., "anthropic/claude-sonnet-4-5")
49-
for _, agent := range cfg.Agents {
50-
if agent.Model == "" || agent.Model == "auto" {
51-
continue
52-
}
53-
54-
var resolvedModels []string
55-
for modelRef := range strings.SplitSeq(agent.Model, ",") {
56-
if provider, model, ok := strings.Cut(modelRef, "/"); ok {
57-
if resolved := store.ResolveModelAlias(ctx, provider, model); resolved != model {
58-
resolvedModels = append(resolvedModels, provider+"/"+resolved)
59-
continue
60-
}
61-
}
62-
resolvedModels = append(resolvedModels, modelRef)
63-
}
64-
65-
cfg.Agents.Update(agent.Name, func(a *latest.AgentConfig) {
66-
a.Model = strings.Join(resolvedModels, ",")
67-
})
68-
}
6947
}
7048

7149
// hasCustomBaseURL checks if a model config has a custom base_url, either directly

pkg/config/model_alias_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func TestResolveModelAliases(t *testing.T) {
4545
},
4646
},
4747
{
48-
name: "resolves inline model in agent",
48+
name: "does not resolve inline model in agent",
4949
cfg: &latest.Config{
5050
Models: map[string]latest.ModelConfig{},
5151
Agents: []latest.AgentConfig{
@@ -55,7 +55,7 @@ func TestResolveModelAliases(t *testing.T) {
5555
expected: &latest.Config{
5656
Models: map[string]latest.ModelConfig{},
5757
Agents: []latest.AgentConfig{
58-
{Name: "root", Model: "anthropic/claude-sonnet-4-5-20250929"},
58+
{Name: "root", Model: "anthropic/claude-sonnet-4-5"},
5959
},
6060
},
6161
},
@@ -107,7 +107,7 @@ func TestResolveModelAliases(t *testing.T) {
107107
},
108108
},
109109
{
110-
name: "handles comma-separated models",
110+
name: "does not resolve comma-separated inline models in agent",
111111
cfg: &latest.Config{
112112
Models: map[string]latest.ModelConfig{},
113113
Agents: []latest.AgentConfig{
@@ -117,7 +117,7 @@ func TestResolveModelAliases(t *testing.T) {
117117
expected: &latest.Config{
118118
Models: map[string]latest.ModelConfig{},
119119
Agents: []latest.AgentConfig{
120-
{Name: "root", Model: "anthropic/claude-sonnet-4-5-20250929,my_ref"},
120+
{Name: "root", Model: "anthropic/claude-sonnet-4-5,my_ref"},
121121
},
122122
},
123123
},

0 commit comments

Comments
 (0)