fix: bedrock interleaved_thinking defaults to true and add logging for provider_opts mismatches

- Default interleaved_thinking to true, matching schema documentation
- Warn when thinking_budget is set but interleaved_thinking is explicitly disabled
- Add debug logging in providerutil when provider_opts values have wrong types

Assisted-By: docker-agent

Author: dgageot

pkg/model/provider/bedrock/client.go

@@ -279,7 +279,21 @@ func (c *Client) buildInferenceConfig(thinkingEnabled bool) *types.InferenceConf
 }
 
 func (c *Client) interleavedThinkingEnabled() bool {
-	return getProviderOpt[bool](c.ModelConfig.ProviderOpts, "interleaved_thinking")
+	// Default to true, matching the documented schema behavior.
+	v, ok := c.ModelConfig.ProviderOpts["interleaved_thinking"]
+	if !ok {
+		return true
+	}
+	b, ok := v.(bool)
+	if !ok {
+		slog.Warn("Bedrock provider_opts type mismatch",
+			"key", "interleaved_thinking",
+			"expected_type", "bool",
+			"actual_type", fmt.Sprintf("%T", v),
+			"value", v)
+		return true
+	}
+	return b
 }
 
 // isThinkingEnabled returns true if a valid thinking budget is configured.
@@ -349,6 +363,9 @@ func (c *Client) buildAdditionalModelRequestFields() document.Interface {
 			if c.interleavedThinkingEnabled() {
 				fields["anthropic_beta"] = []string{"interleaved-thinking-2025-05-14"}
 				slog.Debug("Bedrock request using interleaved thinking beta")
+			} else {
+				slog.Warn("Bedrock thinking_budget is set but interleaved_thinking is explicitly disabled; " +
+					"the anthropic_beta header will not be sent, which may cause the thinking budget to be ignored")
 			}
 		}
 	}

pkg/model/provider/bedrock/client_test.go

@@ -854,7 +854,7 @@ func TestInterleavedThinkingEnabled_NotSet(t *testing.T) {
 		},
 	}
 
-	assert.False(t, client.interleavedThinkingEnabled())
+	assert.True(t, client.interleavedThinkingEnabled())
 }
 
 func TestInterleavedThinkingEnabled_NilProviderOpts(t *testing.T) {
@@ -870,7 +870,7 @@ func TestInterleavedThinkingEnabled_NilProviderOpts(t *testing.T) {
 		},
 	}
 
-	assert.False(t, client.interleavedThinkingEnabled())
+	assert.True(t, client.interleavedThinkingEnabled())
 }
 
 func TestBuildAdditionalModelRequestFields_WithInterleavedThinking(t *testing.T) {

pkg/model/provider/providerutil/provider_opts.go

@@ -1,6 +1,10 @@
 package providerutil
 
-import "math"
+import (
+	"fmt"
+	"log/slog"
+	"math"
+)
 
 // GetProviderOptFloat64 extracts a float64 value from provider opts.
 // YAML may parse numbers as float64 or int, so this handles both.
@@ -22,6 +26,11 @@ func GetProviderOptFloat64(opts map[string]any, key string) (float64, bool) {
 	case int64:
 		return float64(n), true
 	default:
+		slog.Debug("provider_opts type mismatch, ignoring",
+			"key", key,
+			"expected_type", "numeric",
+			"actual_type", fmt.Sprintf("%T", v),
+			"value", v)
 		return 0, false
 	}
 }
@@ -45,8 +54,15 @@ func GetProviderOptInt64(opts map[string]any, key string) (int64, bool) {
 		if n == math.Trunc(n) && n >= math.MinInt64 && n <= math.MaxInt64 {
 			return int64(n), true
 		}
+		slog.Debug("provider_opts: float64 value is not a valid integer",
+			"key", key, "value", v)
 		return 0, false
 	default:
+		slog.Debug("provider_opts type mismatch, ignoring",
+			"key", key,
+			"expected_type", "integer",
+			"actual_type", fmt.Sprintf("%T", v),
+			"value", v)
 		return 0, false
 	}
 }